3c53f52c6d
remove some debugging crap from c9e30060d4
2023-05-19 22:28:32 -07:00
542cf2433a
Reduce allocation spam in Jaguar disassembly functions
2023-05-19 22:26:45 -07:00
c9e30060d4
Rework the Reader/Writer callbacks for the WaterboxHost, a bit nicer here working with the userdata
...
Also make it so initial loading uses the zstdstream or filestream directly instead of a memorystream with it all loaded
something of note, not really happy with how these read/write callbacks get used in practice, it seems they get spammed in small chunks
for initial loading, it's 8192 byte chunks each, which can be a LOT of callbacks, depending on core size (gpgx is ~500, MAME is ~22K)
similarly, savestates suffer a similar issue, although instead it's a ton of 4096 byte chunks (page size eh?)
The unmanaged <-> managed transitions obviously are not exactly performant, and I imagine are taking a significant portion of the time here
Perhaps some buffering strategy should come in on the native waterboxhost side to alleviate callback spam?
2023-05-19 22:26:45 -07:00
37ef137aa9
Update GitLab CI links in readme
2023-05-20 11:27:00 +10:00
99a6b1d339
add hotkey for toggling the 'Display Nothing" feature
2023-05-19 20:05:16 -05:00
8a13793d00
Turn WaterboxHostNative ReturnData to a struct, misc cleanups elsewhere
2023-05-18 22:21:17 -07:00
332143ea8d
invalidate cram caches when poking, maybe
2023-05-18 21:14:57 -07:00
63ec0cecc7
fix picodrive's cram/vsram sizes
2023-05-18 19:29:42 -07:00
473d3cc294
fix #3662
2023-05-18 19:09:08 -07:00
ea854ff39d
make discohawk form a bit bigger
...
all the formats supported means the box wasn't big enough to display all of them lol
2023-05-18 07:28:10 -07:00
fe79b69123
(Partial) .nrg support
...
TAO support isn't complete, a lot of sanity checking isn't done yet
2023-05-18 07:14:14 -07:00
3d30f52e7c
Fix LogWindow treating everything as ascii
...
hopefully this doesn't break anything
2023-05-17 14:54:18 +02:00
f11b5bc9c4
fixup CDI generated subcode (not sure why I did that)
...
have it generate "leadin" and "leadout" tracks for multisession discs... this is almost certainly wrong for leadin (doesn't matter so far), leadout is probably right...
2023-05-12 20:47:29 -07:00
0e6d5fb708
minor addendum to 2012b083f6
2023-05-12 03:28:14 -07:00
2012b083f6
Fixup multisession handling with MDS and improve its track/sector size handling, also maybe fix it entirely? (not sure if this ever worked)
...
Move the various synths using the CUE SS_Base to a file, mostly just a nicer organizational change as MDS and CDI use one of these but not CUE
Misc improvements elsewhere
2023-05-12 02:44:05 -07:00
1f3068fe77
fix synthesizing disc tracks with multisession discs when the first session has a large amount of tracks
...
FirstRecordedTrackNumber only works here for the first session, for future sessions it doesn't work and may just result in out of range exception
2023-05-11 02:57:14 -07:00
858ea372a9
Fix Jaguar CD detection for Caves of Fear
2023-05-11 02:28:33 -07:00
1adb2b45a2
(VirtualJaguar) swap user and interrupt stack pointers when going to supervisor mode for external interrupts, fixes Black ICE
...
also slight improvements to cd bios hle (don't really do much, but better safe than sorry)
2023-05-10 23:04:49 -07:00
e3c27813b6
fix the fix in 45a0c8cffb
2023-05-10 05:37:03 -07:00
45a0c8cffb
another fix for 9551394
2023-05-10 05:23:24 -07:00
c52a950c41
Fix dumping CCDs with multisession discs, fix oopsies with CDI parsing giving the wrong last recorded track number
2023-05-10 04:58:37 -07:00
2379650e1b
Implement error and verbose message callbacks for rcheevos (currently they just output to the console)
...
Implement debug option for hashing with more pure rcheevos logic, mostly just useful for figuring out disc hashing issues
2023-05-10 03:11:50 -07:00
d3a689c589
Resolve #3650 . Also fix a bug which caused overwriting lua scripts with a new lua script to fail (fixes 380e459bec)
2023-05-08 03:01:41 -07:00
f677e92504
fix TOC field mixup with Jaguar CD
2023-05-07 22:09:52 -07:00
40e21b716e
fix 955139454a
2023-05-07 02:59:38 -07:00
7d5a1d5c98
Lower CPU usage from RCheevos http stuff
2023-05-07 02:41:07 -07:00
68cd28c28a
fix directionals and other common buttons being dropped from controller inputs when hotkeys overrode controller inputs
2023-05-07 01:00:13 -07:00
4a752f66b7
Add Analyzer to require checking or discarding `TryGetValue`
...
I'm pretty sure all the existing instances were intended to use `default(T)` if
the key isn't present, except maybe the cheatcode converters but I don't care to
rewrite those at the moment
2023-05-05 06:27:15 +10:00
384a4e1e18
Bump version info post-release
2023-05-04 08:10:07 +10:00
99fb1ba905
Fix typo in release package script
...
fixes e0e5a68c5
2023-05-04 03:18:14 +10:00
e0e5a68c50
Refactor release package script, shrinking output slightly
...
more shrinking may be possible, but there are diminishing returns, especially
when MAME is so big (#3505 )
2023-05-04 03:08:06 +10:00
36fae775d4
Prevent annoying waits when using firmware manager with DSi NANDs present
2023-05-03 02:19:56 -07:00
5f6d70ac46
Fix random crashes with rcheevos. The issue was that rc_runtime_t can store pointers to itself, which is bad when rcheevos expected the user to allocate that struct and did not provide functions for that. I've added that functionality and PR'd it (I'll fixup submodule to point to upstream when it's merged)
...
PR can be found here: https://github.com/RetroAchievements/rcheevos/pull/239
Also minor fixes wrt the ContinueWith usage in InternalDoRequest
2023-05-03 01:54:57 -07:00
76c8b33f16
least-effort "fix" octoshock exe load hard crash
2023-05-03 07:40:39 +02:00
a5efc8f93b
fix, update and rebuild octoshock project
2023-05-03 07:35:53 +02:00
248b8ab984
Fixup bad threading (no, you cannot access rcheevo's _runtime in a separate thread! main thread use only!). Should fix up some random crashes
...
Slightly change up the request model, now InternalDoRequest does not block
Fixup logic of ToSoftcoreMode (and comments so it isn't screwed up again)
2023-05-02 21:47:09 -07:00
8ef1d93891
Prevent UI thread deadlocking on Dispose()'ing rcheevos stuff
2023-05-02 17:18:31 -07:00
b9a983f1fe
Fix typo causing crash with SMSHawk with RetroAchievements & Hardcore Mode
2023-05-02 17:08:39 -07:00
41d94e4262
Change up multithreaded rendering in melonDS
...
Instead of creating a new Task and destroying it every frame, just create a new thread and call the delegate when needed.
Also allow for rendering a frame twice, this is actually possible anyways (albeit rarely done).
This should also help against a potential deadlock due to the Task.Wait call on the UI thread (which has special semantics in WinForms)
Also minor nitpicks in RCheevos code
2023-05-02 16:52:48 -07:00
b517228475
Refactor rcheevo http requests (again). This should better protect against the UI thread deadlocking due to Task semantics with WinForms
2023-05-01 03:50:49 -07:00
e065263ff2
MAME does mark bad dumps, but it only keeps their info if good dump is not known yet. once a good dump appears, its info replaces the bad one.
...
so simply sticking to newest rom sets is the safest, otherwise there's little user control, because there's no global list of all known dumps with indications which of them are bad and what to use instead.
2023-04-30 14:07:08 +03:00
2010f5e15c
disable leaderboard list form, for now, and revert efa6505
...
see that commit for details on issues with this form (this form is kind of useless anyways, meh)
2023-04-28 18:37:06 -07:00
8a5921182e
Add Analyzer to disallow discarding locals e.g. `_ = result;`
...
fixes 70bd081a9a2185d9ef
2023-04-29 01:52:43 +10:00
a2185d9ef0
fix 70bd081a93
...
The entire call is skipped in release mode if you place it inside a Debug.Assert.
2023-04-28 03:14:56 -07:00
a6deee765f
fix stackoverflows in mame with games using k001006_device (e.g. windheat)
2023-04-27 00:55:12 -07:00
66f26bb1c1
Create and use `IDictionary.GetValueOrPut{,New,New1}` extensions
2023-04-27 17:25:03 +10:00
fa48278354
Enable MEN014 and fix noncompliance
...
"Prefer TryGetValue"
2023-04-27 17:24:55 +10:00
c8589de5c6
fix #3648
2023-04-26 23:05:11 -07:00
102dee9622
Fix some SMS audio inaccuracies (squashed PR #3602 )
...
* fix noise audio channel on SMS VDP
* Update SN76489sms.cs
also, white noise is generated by XORing bits 0 and 3, not 0 and 1, on an SMS/GG VDP
* Update SN76489sms.cs
reverting commit #7b857e7
2023-04-27 15:46:52 +10:00
dd30a389a0
TAStudio/PatternsForm: Block deletion of loop entry which would cause a crash
2023-04-27 15:14:44 +10:00
CasualPokePlayer