Commit Graph

53 Commits

Author SHA1 Message Date
YoshiRulz 8332a6bd5e
Add `Roslynator.Analyzers` 2025-01-29 22:16:49 +10:00
YoshiRulz eaf9906741
Leave a note re: `$(EmitCompilerGeneratedFiles)` 2024-08-27 22:57:33 +10:00
YoshiRulz cbf0728d4e
Scale back autorestore of dotnet tools to only be in `BizHawk.Common`
fixes f58b4640c
and to be fair this was the one place actually using a tool during the
build process, so it makes sense to keep them together I guess
2024-06-07 22:11:26 +10:00
YoshiRulz f58b4640c5
Have local dotnet tools restored with NuGet packages
reverts 8f7e61339
2024-06-07 22:03:16 +10:00
YoshiRulz a1256782fc
Bump `<LangVersion/>` for satellite .NET projects 2024-05-30 10:44:55 +10:00
YoshiRulz b8c600783a
Apply `<GenerateDocumentationFile/>` to satellite .NET projects 2024-05-30 09:22:17 +10:00
James Groom bd786a0e95
Downgrade `<LangVersion/>` for external .NET projects
fixes 62b8ec457
2024-05-29 10:36:38 +10:00
Morilli 62b8ec4578 Bump LangVersion to 12
- fix IDE0100
- fix IDE0230
- a couple of usages of the collection expression
2024-05-28 15:13:14 +02:00
James Groom 96d5518cc0
Change how `$(DefineConstants)` is initialised
this may explain why I was having trouble with it earlier
2024-04-30 17:59:09 +10:00
James Groom 82d80bf4bf
Embed debug info for main solution only
fixes 0e892a5f1
2024-04-03 23:32:29 +00:00
Morilli 0e892a5f17 Improve debug output
- use embedded debug information instead of portable pdbs
- always emit debug symbols. The `DebugSymbols` property is kind of bugged (see https://github.com/dotnet/msbuild/issues/2169), but it does have advantages when set
2024-04-03 22:38:10 +02:00
Morilli 1f4a12c6c4 Remove duplicated comment 2024-04-03 21:38:56 +02:00
YoshiRulz d31047ffc3 Use NuGet central package management 2024-02-14 16:24:31 +00:00
James Groom 197b357419
Migrate code analysis ruleset to new format
fixes 362269c98
2023-11-22 05:13:48 +00:00
James Groom 09e3ed6f26
Rename .globalconfig
specific filename meant it was implicitly and automatically picked up, similar to Directory.Build.props; now it's explicit
2023-11-22 04:01:43 +00:00
Moritz Bender 362269c982
Establish basic style analyzer rules (#3759)
* Fix analyzer nullable error

can't disable them in CA1305 xdd

* .editorconfig -> .globalconfig

* Add basic set of style analyzer rules

* dotnet format output

* Some additional fixes

* Apply manual simplification

* Transform some enum comparisons

* fix typo

* add TODO
2023-08-30 23:08:21 +02:00
Morilli c10d2927ca bump AnalysisModeUsage to Recommended
fixes CA2211, CA2215, CA2241, CA2251

silence CA1816 because it's unnecessary

reduce severity of CA2201 because I like the concept but don't wanna fix them all
2023-08-14 14:18:45 -07:00
Morilli 71e08e27b9 bump AnalysisModePerformance to Recommended
fixes CA1841

silence CA1805 and CA1822 because of sheer amount of violations

reduce severity of CA1838 because I don't wanna fix it lol
2023-08-14 14:18:45 -07:00
Morilli 18a742195b bump AnalysisModeReliability to Recommended 2023-08-14 14:18:45 -07:00
Morilli 612ebb8959 Bump AnalysisModeMaintainability to Recommended 2023-08-14 14:18:45 -07:00
Morilli 8e557b0b9d bump AnalysisModeGlobalization to Recommended
fixes CA1304, CA1309, CA1310, CA1311

temporarily silences CA1305

reduce severity of CA2101
2023-08-14 14:18:45 -07:00
Morilli 4c00ec54e7 Bump AnalysisLevel, remove legacy rules 2023-08-14 14:18:45 -07:00
YoshiRulz 65ffa3fc2e
Blindly update NuGet deps
temporarily disabled MA0020
2023-04-16 09:02:40 +10:00
YoshiRulz eb6f2864ff
Only set `<PathMap/>` for Release builds
fixes 5dc385e22; also skip `SolutionDir` override if building projects
individually
2023-03-17 06:37:38 +10:00
YoshiRulz 5dc385e228
Set `<PathMap/>` so per-machine paths don't leak into build output 2023-03-16 12:39:26 +10:00
YoshiRulz 389fd5015f
s/ProjectDir/MSBuildProjectDirectory/ in MSBuild include files
I don't think anything was broken, this is just a precaution
2023-03-16 12:39:26 +10:00
YoshiRulz 38b5f16ccc
Refactor enable Roslyn Analyzers flag
kept the old name, but turns out `-p:RunAnalyzersDuringBuild=true` also works
...good thing the old name wasn't documented
2023-03-16 12:39:25 +10:00
YoshiRulz c816400e54
Update schema in `.stylecop.json` to match package version 2023-03-16 12:39:21 +10:00
YoshiRulz 697c10e3e6
Enable MA0015 and fix noncompliance
"Specify the parameter name in ArgumentException"
needed to update package because this rule was broken until now
2022-07-22 03:51:46 +10:00
YoshiRulz 6b4e526a44
Actually run all the Analyzers for ext. tools, update Analyzers
fixes 6f372820a
2022-07-15 22:22:19 +10:00
YoshiRulz 6f372820a7
Allow C# 10 in satellite projects, enable Analyzers on ext. tools 2022-07-14 04:26:27 +10:00
YoshiRulz 6077bcf5af
Enable "strict" compiler flag and fix noncompliance
couldn't find official docs for this, but I got it from:
https://www.meziantou.net/csharp-compiler-strict-mode.htm
and it definitely does SOMETHING
2022-07-14 04:26:27 +10:00
zeromus a5fb4caad0 change languageversion back to 9.0 so we can use vs2019 and fix one related build error 2022-03-06 01:15:46 -05:00
YoshiRulz 1655c191e0
Bump LangVersion, move key name overrides to separate file 2022-02-14 01:51:42 +10:00
CasualPokePlayer 2d9651fa89 Revert "sayonara appveyor"
This reverts commit 3b9cfc7c50.
2022-01-29 21:56:08 -08:00
CasualPokePlayer 3b9cfc7c50 sayonara appveyor 2022-01-29 18:55:51 -08:00
YoshiRulz 908d4519c5
Use <ContinuousIntegrationBuild/> prop 2021-11-15 18:19:15 +10:00
YoshiRulz d04724b0d2
Allow non-string resources again 2021-07-01 11:04:32 +10:00
YoshiRulz 1f0e058ef5
Blindly update <PackageReference/>s 2021-06-21 12:13:42 +10:00
YoshiRulz 26eaa22be2
Update StyleCop, migrate FxCop to NetAnalyzers (built-in) 2021-04-04 14:15:22 +10:00
YoshiRulz ef76d8510e
Cleanup project files 2021-01-18 09:26:51 +10:00
YoshiRulz 0093c16d79
Bump .NET SDK to 5.0.100, bump C# to 9.0
BizHawk.Tests executable needs to run in CI, but the 5.0 SDK image can't run
Core 3.1 apps somehow, so I bumped that too
2020-11-23 21:48:10 +10:00
YoshiRulz f8e624befe
Create common property IsTargetingNetFramework
* if true, will add reference assemblies <PackageReference/>
* slightly less dumb <Move/>
2020-09-22 22:11:00 +10:00
YoshiRulz 17ff66c61b
Opt-in to .NET 5 SDK's extra static analysis, update Analyzer packages
the extra CSxxxx rules should be available for Framework too if using the new
SDK, I haven't tried
2020-08-29 00:51:34 +10:00
YoshiRulz ebd9645c1e
Cleanup assembly attributes
We're not using this metadata for anything, except one [InternalsVisibleTo] for
unit tests, and a half-assed version check in EmuHawk.Program.
2020-08-01 11:56:30 +10:00
YoshiRulz 318c6a7994
Add an easy way to #define symbols when building
-p:MachineExtraCompilationFlag=SYMBOL_NAME
2020-06-30 14:44:39 +10:00
nattthebear 12227f4836 fix debugging on omnisharp 2020-05-28 06:50:54 -04:00
YoshiRulz 2b8c0edcc2
Reorganise *.props 2020-02-23 06:17:35 +10:00
James Groom 46a4d8ffa9
Retargetting non-executable projects to .NET Standard (#1801)
* Retarget BizHawk.Emulation.* to .NET Standard 2.0

* Retarget BizHawk.Bizware.BizwareGL to .NET Standard 2.0

In practice this mostly involves moving classes to BizHawk.Client.EmuHawk.
2020-02-18 10:31:49 -06:00
zeromus ae795e1f96 we have to use AnyCpu in order for winforms designer to work 2020-01-27 21:44:40 -05:00