Apply `<GenerateDocumentationFile/>` to satellite .NET projects

Common.props

@@ -16,9 +16,10 @@
 		<ErrorReport>prompt</ErrorReport>
 		<Features>strict</Features>
 		<IsTargetingNetFramework>$(TargetFramework.StartsWith("net4"))</IsTargetingNetFramework>
+		<GenerateDocumentationFile>true</GenerateDocumentationFile> <!-- it would be nice to rename these to *.api_reference.xml or something, but it seems https://github.com/dotnet/standard/issues/614 was never fixed -->
 		<LangVersion>10.0</LangVersion>
 		<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
-		<NoWarn>SA0001</NoWarn>
+		<NoWarn>$(NoWarn);CS1591;SA0001</NoWarn>
 		<Nullable>enable</Nullable>
 		<PlatformTarget>AnyCPU</PlatformTarget>
 		<RunAnalyzersDuringBuild>true</RunAnalyzersDuringBuild>

ExternalProjects/BizHawk.Analyzer/TryGetValueImplicitDiscardAnalyzer.cs

@@ -4,7 +4,6 @@ using System.Collections.Immutable;
 using System.Linq;
 
 using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.Operations;
 

ExternalProjects/iso-parser/ISOFile.cs

@@ -89,6 +89,7 @@ namespace ISOParser
 		/// </summary>
 		/// <param name="s">The stream which we are using to parse the image. 
 		/// Should already be located at the start of the image.</param>
+		/// <param name="startSector">will seek forward this number of sectors before reading</param>
 		public bool Parse(Stream s, int startSector = 16)
 		{
 			this.VolumeDescriptors = new List<ISOVolumeDescriptor>();

ExternalToolProjects/AutoGenConfig/ConfigEditorUIGenerators.cs

@@ -171,6 +171,7 @@ namespace BizHawk.Experiment.AutoGenConfig
 
 			public readonly ComparisonColors ComparisonColors;
 
+			/// <param name="cache">global cache</param>
 			/// <param name="colors">default of <see langword="null"/> uses <see cref="ConfigEditorUIGenerators.ComparisonColors.Defaults"/></param>
 			public ConfigEditorMetadata(ConfigEditorCache cache, ComparisonColors? colors = null)
 			{
@@ -209,7 +210,7 @@ namespace BizHawk.Experiment.AutoGenConfig
 
 			/// <remarks>
 			/// Default implementation didn't play nice with <see langword="null"/>, so multiple behaviours are available for custom generators:
-			/// inherit from <see cref="ConfigPropEditorUIGenRefT"/> or <see cref="ConfigPropEditorUIGenValT"/> instead.
+			/// inherit from <see cref="ConfigPropEditorUIGenRefT{T,T}"/> or <see cref="ConfigPropEditorUIGenValT{T,T}"/> instead.
 			/// </remarks>
 			protected abstract bool MatchesBaseline(TListed c, ConfigEditorMetadata metadata);
 
@@ -273,12 +274,12 @@ namespace BizHawk.Experiment.AutoGenConfig
 			where TValue : class
 		{
 			/// <remarks>
-			/// Checked in <see cref="MatchesBaseline"/> in the case where the baseline value is <see cref="null"/>.
-			/// If its implementation returns <see cref="false"/>, an exception will be thrown, otherwise <see cref="TValueEquality"/>' implementation will be called with <see cref="null"/>.
+			/// Checked in <see cref="MatchesBaseline"/> in the case where the baseline value is <see langword="null"/>.
+			/// If its implementation returns <see langword="false"/>, an exception will be thrown, otherwise <see cref="ConfigPropEditorUIGen{T,T}.TValueEquality"/>' implementation will be called with <see langword="null"/>.
 			/// </remarks>
 			protected abstract bool AllowNull { get; }
 
-			/// <inheritdoc cref="ConfigPropEditorUIGen.MatchesBaseline"/>
+			/// <inheritdoc cref="ConfigPropEditorUIGen{T,T}.MatchesBaseline"/>
 			protected override bool MatchesBaseline(TListed c, ConfigEditorMetadata metadata)
 				=> metadata.BaselineValues[c.Name] is TValue v
 					? TValueEquality(GetTValue(c), v)
@@ -289,7 +290,7 @@ namespace BizHawk.Experiment.AutoGenConfig
 			where TListed : Control
 			where TValue : struct
 		{
-			/// <inheritdoc cref="ConfigPropEditorUIGen.MatchesBaseline"/>
+			/// <inheritdoc cref="ConfigPropEditorUIGen{T,T}.MatchesBaseline"/>
 			protected override bool MatchesBaseline(TListed c, ConfigEditorMetadata metadata)
 				=> metadata.BaselineValues[c.Name] is TValue v ? TValueEquality(GetTValue(c), v) : throw new Exception();
 		}

ExternalToolProjects/DATParser/DATConverter.cs

@@ -6,9 +6,6 @@ using System.Linq;
 using System.Windows.Forms;
 using System.IO;
 
-using BizHawk.Client.Common;
-using BizHawk.Client.EmuHawk;
-
 namespace BizHawk.DATTool
 {
 	public partial class DATConverter : Form

src/MainSlnCommon.props

@@ -4,9 +4,8 @@
 		<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
 		<DebugType>embedded</DebugType>
 		<DefineConstants>$(DefineConstants);AVI_SUPPORT</DefineConstants>
-		<GenerateDocumentationFile>true</GenerateDocumentationFile> <!-- it would be nice to rename these to *.api_reference.xml or something, but it seems https://github.com/dotnet/standard/issues/614 was never fixed -->
 		<LangVersion>12.0</LangVersion>
-		<NoWarn>$(NoWarn);CS1573;CS1591;NU1702</NoWarn>
+		<NoWarn>$(NoWarn);CS1573;NU1702</NoWarn>
 		<ResolveAssemblyWarnOrErrorOnTargetArchitectureMismatch>None</ResolveAssemblyWarnOrErrorOnTargetArchitectureMismatch>
 	</PropertyGroup>
 	<PropertyGroup Condition=" '$(Configuration)' == 'Release' And '$(SolutionDir)' != '' ">