ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

N64 Sync Settings - remove GetPluginSettings from IPluginSettings and make an extension method, rather than having every plugin implement the same method in the same way

This commit is contained in:
adelikat 2014-07-20 18:25:47 +00:00
parent 15c7dfe269
commit f5ff868c50
5 changed files with 21 additions and 69 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
BizHawk.Emulation.Cores/Consoles/Nintendo/N64/N64SyncSettings.Glide.cs
View File

@ -338,23 +338,6 @@ namespace BizHawk.Emulation.Cores.Nintendo.N64
{
return PluginType.Glide;
}
public Dictionary<string, object> GetPluginSettings()
{
//TODO: deal witn the game depedent settings
var dictionary = new Dictionary<string, object>();
var members = this.GetType().GetMembers();
foreach (var member in members)
{
if (member.MemberType == MemberTypes.Property)
{
var field = this.GetType().GetProperty(member.Name).GetValue(this, null);
dictionary.Add(member.Name, field);
}
}
return dictionary;
}
}
}
}

17
BizHawk.Emulation.Cores/Consoles/Nintendo/N64/N64SyncSettings.GlideMk2.cs
View File

@ -282,23 +282,6 @@ namespace BizHawk.Emulation.Cores.Nintendo.N64
{
return PluginType.GlideMk2;
}
public Dictionary<string, object> GetPluginSettings()
{
//TODO: deal witn the game depedent settings
var dictionary = new Dictionary<string, object>();
var members = this.GetType().GetMembers();
foreach (var member in members)
{
if (member.MemberType == MemberTypes.Property)
{
var field = this.GetType().GetProperty(member.Name).GetValue(this, null);
dictionary.Add(member.Name, field);
}
}
return dictionary;
}
}
}

17
BizHawk.Emulation.Cores/Consoles/Nintendo/N64/N64SyncSettings.Jabo.cs
View File

@ -39,23 +39,6 @@ namespace BizHawk.Emulation.Cores.Nintendo.N64
}
public Dictionary<string, object> GetPluginSettings()
{
//TODO: deal witn the game depedent settings
var dictionary = new Dictionary<string, object>();
var members = this.GetType().GetMembers();
foreach (var member in members)
{
if (member.MemberType == MemberTypes.Property)
{
var field = this.GetType().GetProperty(member.Name).GetValue(this, null);
dictionary.Add(member.Name, field);
}
}
return dictionary;
}
[DefaultValue(ANISOTROPIC_FILTERING_LEVEL.FourTimes)]
[DisplayName("Anisotropic filtering")]
[Description("Anisotropic filtering level")]

17
BizHawk.Emulation.Cores/Consoles/Nintendo/N64/N64SyncSettings.Rice.cs
View File

@ -399,23 +399,6 @@ namespace BizHawk.Emulation.Cores.Nintendo.N64
{
return PluginType.Rice;
}
public Dictionary<string, object> GetPluginSettings()
{
//TODO: deal witn the game depedent settings
var dictionary = new Dictionary<string, object>();
var members = this.GetType().GetMembers();
foreach (var member in members)
{
if (member.MemberType == MemberTypes.Property)
{
var field = this.GetType().GetProperty(member.Name).GetValue(this, null);
dictionary.Add(member.Name, field);
}
}
return dictionary;
}
}
}
}

22
BizHawk.Emulation.Cores/Consoles/Nintendo/N64/N64SyncSettings.cs
View File

@ -3,6 +3,7 @@ using BizHawk.Emulation.Common;
using BizHawk.Emulation.Cores.Nintendo.N64.NativeApi;
using Newtonsoft.Json;
using System.ComponentModel;
using System.Reflection;
namespace BizHawk.Emulation.Cores.Nintendo.N64
{
@ -113,7 +114,26 @@ namespace BizHawk.Emulation.Cores.Nintendo.N64
public interface IPluginSettings
{
PluginType GetPluginType();
Dictionary<string, object> GetPluginSettings();
void FillPerGameHacks(GameInfo game);
}
public static class PluginExtensions
{
public static Dictionary<string, object> GetPluginSettings(this IPluginSettings plugin)
{
// TODO: deal witn the game depedent settings
var dictionary = new Dictionary<string, object>();
var members = plugin.GetType().GetMembers();
foreach (var member in members)
{
if (member.MemberType == MemberTypes.Property)
{
var field = plugin.GetType().GetProperty(member.Name).GetValue(plugin, null);
dictionary.Add(member.Name, field);
}
}
return dictionary;
}
}
}