diff --git a/Common.props b/Common.props
index 75784b774c..b3d8f59534 100644
--- a/Common.props
+++ b/Common.props
@@ -16,9 +16,10 @@
prompt
strict
$(TargetFramework.StartsWith("net4"))
+ true
10.0
true
- SA0001
+ $(NoWarn);CS1591;SA0001
enable
AnyCPU
true
diff --git a/ExternalProjects/BizHawk.Analyzer/TryGetValueImplicitDiscardAnalyzer.cs b/ExternalProjects/BizHawk.Analyzer/TryGetValueImplicitDiscardAnalyzer.cs
index 8f1ab1dc64..41051fe009 100644
--- a/ExternalProjects/BizHawk.Analyzer/TryGetValueImplicitDiscardAnalyzer.cs
+++ b/ExternalProjects/BizHawk.Analyzer/TryGetValueImplicitDiscardAnalyzer.cs
@@ -4,7 +4,6 @@ using System.Collections.Immutable;
using System.Linq;
using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.Diagnostics;
using Microsoft.CodeAnalysis.Operations;
diff --git a/ExternalProjects/iso-parser/ISOFile.cs b/ExternalProjects/iso-parser/ISOFile.cs
index 4ebce8fbd4..13862830cd 100644
--- a/ExternalProjects/iso-parser/ISOFile.cs
+++ b/ExternalProjects/iso-parser/ISOFile.cs
@@ -89,6 +89,7 @@ namespace ISOParser
///
/// The stream which we are using to parse the image.
/// Should already be located at the start of the image.
+ /// will seek forward this number of sectors before reading
public bool Parse(Stream s, int startSector = 16)
{
this.VolumeDescriptors = new List();
diff --git a/ExternalToolProjects/AutoGenConfig/ConfigEditorUIGenerators.cs b/ExternalToolProjects/AutoGenConfig/ConfigEditorUIGenerators.cs
index 87dfd02fd0..3cae1bdb42 100644
--- a/ExternalToolProjects/AutoGenConfig/ConfigEditorUIGenerators.cs
+++ b/ExternalToolProjects/AutoGenConfig/ConfigEditorUIGenerators.cs
@@ -171,6 +171,7 @@ namespace BizHawk.Experiment.AutoGenConfig
public readonly ComparisonColors ComparisonColors;
+ /// global cache
/// default of uses
public ConfigEditorMetadata(ConfigEditorCache cache, ComparisonColors? colors = null)
{
@@ -209,7 +210,7 @@ namespace BizHawk.Experiment.AutoGenConfig
///
/// Default implementation didn't play nice with , so multiple behaviours are available for custom generators:
- /// inherit from or instead.
+ /// inherit from or instead.
///
protected abstract bool MatchesBaseline(TListed c, ConfigEditorMetadata metadata);
@@ -273,12 +274,12 @@ namespace BizHawk.Experiment.AutoGenConfig
where TValue : class
{
///
- /// Checked in in the case where the baseline value is .
- /// If its implementation returns , an exception will be thrown, otherwise ' implementation will be called with .
+ /// Checked in in the case where the baseline value is .
+ /// If its implementation returns , an exception will be thrown, otherwise ' implementation will be called with .
///
protected abstract bool AllowNull { get; }
- ///
+ ///
protected override bool MatchesBaseline(TListed c, ConfigEditorMetadata metadata)
=> metadata.BaselineValues[c.Name] is TValue v
? TValueEquality(GetTValue(c), v)
@@ -289,7 +290,7 @@ namespace BizHawk.Experiment.AutoGenConfig
where TListed : Control
where TValue : struct
{
- ///
+ ///
protected override bool MatchesBaseline(TListed c, ConfigEditorMetadata metadata)
=> metadata.BaselineValues[c.Name] is TValue v ? TValueEquality(GetTValue(c), v) : throw new Exception();
}
diff --git a/ExternalToolProjects/DATParser/DATConverter.cs b/ExternalToolProjects/DATParser/DATConverter.cs
index 5ee0fb304e..6f06d3a16a 100644
--- a/ExternalToolProjects/DATParser/DATConverter.cs
+++ b/ExternalToolProjects/DATParser/DATConverter.cs
@@ -6,9 +6,6 @@ using System.Linq;
using System.Windows.Forms;
using System.IO;
-using BizHawk.Client.Common;
-using BizHawk.Client.EmuHawk;
-
namespace BizHawk.DATTool
{
public partial class DATConverter : Form
diff --git a/References/BizHawk.Analyzer.dll b/References/BizHawk.Analyzer.dll
index cefe7b12f3..15b2719117 100644
Binary files a/References/BizHawk.Analyzer.dll and b/References/BizHawk.Analyzer.dll differ
diff --git a/References/ISOParser.dll b/References/ISOParser.dll
index 46570e94af..168c1ac10d 100644
Binary files a/References/ISOParser.dll and b/References/ISOParser.dll differ
diff --git a/src/MainSlnCommon.props b/src/MainSlnCommon.props
index 860e58c28b..9a82e9907a 100644
--- a/src/MainSlnCommon.props
+++ b/src/MainSlnCommon.props
@@ -4,9 +4,8 @@
false
embedded
$(DefineConstants);AVI_SUPPORT
- true
12.0
- $(NoWarn);CS1573;CS1591;NU1702
+ $(NoWarn);CS1573;NU1702
None