Clarify dropdown options in Record Movie dialog

This commit is contained in:
YoshiRulz 2024-10-26 02:33:00 +10:00
parent 90287b3396
commit ab1f002481
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
1 changed files with 7 additions and 6 deletions

View File

@ -13,11 +13,11 @@ namespace BizHawk.Client.EmuHawk
// TODO - Allow relative paths in record TextBox // TODO - Allow relative paths in record TextBox
public sealed class RecordMovie : Form, IDialogParent public sealed class RecordMovie : Form, IDialogParent
{ {
private const string START_FROM_POWERON = "Power-On"; private const string START_FROM_POWERON = "Power-on (clean)";
private const string START_FROM_SAVERAM = "SaveRam"; private const string START_FROM_SAVERAM = "SaveRAM";
private const string START_FROM_SAVESTATE = "Now"; private const string START_FROM_SAVESTATE = "SaveRAM + savestate";
private readonly IMainFormForTools _mainForm; private readonly IMainFormForTools _mainForm;
private readonly Config _config; private readonly Config _config;
@ -102,8 +102,8 @@ namespace BizHawk.Client.EmuHawk
MaxDropDownItems = 32, MaxDropDownItems = 32,
Size = new(152, 21), Size = new(152, 21),
}; };
if (_emulator.HasSavestates()) StartFromCombo.Items.Add(START_FROM_SAVESTATE);
if (_emulator.HasSaveRam()) StartFromCombo.Items.Add(START_FROM_SAVERAM); if (_emulator.HasSaveRam()) StartFromCombo.Items.Add(START_FROM_SAVERAM);
if (_emulator.HasSavestates()) StartFromCombo.Items.Add(START_FROM_SAVESTATE);
DefaultAuthorCheckBox = new() DefaultAuthorCheckBox = new()
{ {
@ -227,7 +227,8 @@ namespace BizHawk.Client.EmuHawk
Directory.CreateDirectory(fileInfo.DirectoryName); Directory.CreateDirectory(fileInfo.DirectoryName);
} }
if (StartFromCombo.SelectedItem.ToString() is START_FROM_SAVESTATE && _emulator.HasSavestates()) var selectedStartFromValue = StartFromCombo.SelectedItem.ToString();
if (selectedStartFromValue is START_FROM_SAVESTATE && _emulator.HasSavestates())
{ {
var core = _emulator.AsStatable(); var core = _emulator.AsStatable();
@ -251,7 +252,7 @@ namespace BizHawk.Client.EmuHawk
movieToRecord.SavestateFramebuffer = _emulator.AsVideoProvider().GetVideoBufferCopy(); movieToRecord.SavestateFramebuffer = _emulator.AsVideoProvider().GetVideoBufferCopy();
} }
} }
else if (StartFromCombo.SelectedItem.ToString() is START_FROM_SAVERAM && _emulator.HasSaveRam()) else if (selectedStartFromValue is START_FROM_SAVERAM && _emulator.HasSaveRam())
{ {
var core = _emulator.AsSaveRam(); var core = _emulator.AsSaveRam();
movieToRecord.StartsFromSaveRam = true; movieToRecord.StartsFromSaveRam = true;