From ab1f002481107d8ceeea8f69a2fd6cbcf9de5993 Mon Sep 17 00:00:00 2001 From: YoshiRulz Date: Sat, 26 Oct 2024 02:33:00 +1000 Subject: [PATCH] Clarify dropdown options in Record Movie dialog --- src/BizHawk.Client.EmuHawk/movie/RecordMovie.cs | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/BizHawk.Client.EmuHawk/movie/RecordMovie.cs b/src/BizHawk.Client.EmuHawk/movie/RecordMovie.cs index 6fcf09c699..7b685a675d 100644 --- a/src/BizHawk.Client.EmuHawk/movie/RecordMovie.cs +++ b/src/BizHawk.Client.EmuHawk/movie/RecordMovie.cs @@ -13,11 +13,11 @@ namespace BizHawk.Client.EmuHawk // TODO - Allow relative paths in record TextBox public sealed class RecordMovie : Form, IDialogParent { - private const string START_FROM_POWERON = "Power-On"; + private const string START_FROM_POWERON = "Power-on (clean)"; - private const string START_FROM_SAVERAM = "SaveRam"; + private const string START_FROM_SAVERAM = "SaveRAM"; - private const string START_FROM_SAVESTATE = "Now"; + private const string START_FROM_SAVESTATE = "SaveRAM + savestate"; private readonly IMainFormForTools _mainForm; private readonly Config _config; @@ -102,8 +102,8 @@ namespace BizHawk.Client.EmuHawk MaxDropDownItems = 32, Size = new(152, 21), }; - if (_emulator.HasSavestates()) StartFromCombo.Items.Add(START_FROM_SAVESTATE); if (_emulator.HasSaveRam()) StartFromCombo.Items.Add(START_FROM_SAVERAM); + if (_emulator.HasSavestates()) StartFromCombo.Items.Add(START_FROM_SAVESTATE); DefaultAuthorCheckBox = new() { @@ -227,7 +227,8 @@ namespace BizHawk.Client.EmuHawk Directory.CreateDirectory(fileInfo.DirectoryName); } - if (StartFromCombo.SelectedItem.ToString() is START_FROM_SAVESTATE && _emulator.HasSavestates()) + var selectedStartFromValue = StartFromCombo.SelectedItem.ToString(); + if (selectedStartFromValue is START_FROM_SAVESTATE && _emulator.HasSavestates()) { var core = _emulator.AsStatable(); @@ -251,7 +252,7 @@ namespace BizHawk.Client.EmuHawk movieToRecord.SavestateFramebuffer = _emulator.AsVideoProvider().GetVideoBufferCopy(); } } - else if (StartFromCombo.SelectedItem.ToString() is START_FROM_SAVERAM && _emulator.HasSaveRam()) + else if (selectedStartFromValue is START_FROM_SAVERAM && _emulator.HasSaveRam()) { var core = _emulator.AsSaveRam(); movieToRecord.StartsFromSaveRam = true;