rename method to try to better describe what it does

This commit is contained in:
adelikat 2020-06-05 19:26:26 -05:00
parent b93d51f46c
commit 8303321586
2 changed files with 6 additions and 6 deletions

View File

@ -17,7 +17,7 @@ namespace BizHawk.Client.Common.MovieConversionExtensions
{ {
public static ITasMovie ToTasMovie(this IMovie old) public static ITasMovie ToTasMovie(this IMovie old)
{ {
string newFilename = GetNewFileName(old.Filename); string newFilename = ConvertFileNameToTasMovie(old.Filename);
var tas = (ITasMovie)MovieService.Get(newFilename); var tas = (ITasMovie)MovieService.Get(newFilename);
tas.CopyLog(old.GetLogEntries()); tas.CopyLog(old.GetLogEntries());
@ -85,7 +85,7 @@ namespace BizHawk.Client.Common.MovieConversionExtensions
public static ITasMovie ConvertToSavestateAnchoredMovie(this ITasMovie old, int frame, byte[] savestate) public static ITasMovie ConvertToSavestateAnchoredMovie(this ITasMovie old, int frame, byte[] savestate)
{ {
string newFilename = GetNewFileName(old.Filename); string newFilename = ConvertFileNameToTasMovie(old.Filename);
var tas = (ITasMovie)MovieService.Get(newFilename); var tas = (ITasMovie)MovieService.Get(newFilename);
tas.BinarySavestate = savestate; tas.BinarySavestate = savestate;
@ -142,7 +142,7 @@ namespace BizHawk.Client.Common.MovieConversionExtensions
public static ITasMovie ConvertToSaveRamAnchoredMovie(this ITasMovie old, byte[] saveRam) public static ITasMovie ConvertToSaveRamAnchoredMovie(this ITasMovie old, byte[] saveRam)
{ {
string newFilename = GetNewFileName(old.Filename); string newFilename = ConvertFileNameToTasMovie(old.Filename);
var tas = (ITasMovie) MovieService.Get(newFilename); var tas = (ITasMovie) MovieService.Get(newFilename);
tas.SaveRam = saveRam; tas.SaveRam = saveRam;
@ -298,7 +298,7 @@ namespace BizHawk.Client.Common.MovieConversionExtensions
.CoreName; .CoreName;
} }
public static string GetNewFileName(string oldFileName) internal static string ConvertFileNameToTasMovie(string oldFileName)
{ {
string newFileName = Path.ChangeExtension(oldFileName, $".{TasMovie.Extension}"); string newFileName = Path.ChangeExtension(oldFileName, $".{TasMovie.Extension}");
int fileSuffix = 0; int fileSuffix = 0;

View File

@ -12,9 +12,9 @@ namespace BizHawk.Common.Tests.Client.Common.Movie
[DataRow("C:\\Temp\\TestMovie.bk2", "C:\\Temp\\TestMovie.tasproj")] [DataRow("C:\\Temp\\TestMovie.bk2", "C:\\Temp\\TestMovie.tasproj")]
[DataRow("C:\\Temp\\TestMovie.tasproj.bk2", "C:\\Temp\\TestMovie.tasproj.tasproj")] [DataRow("C:\\Temp\\TestMovie.tasproj.bk2", "C:\\Temp\\TestMovie.tasproj.tasproj")]
[DataRow("C:\\Temp\\TestMovie.tasproj", "C:\\Temp\\TestMovie.tasproj")] [DataRow("C:\\Temp\\TestMovie.tasproj", "C:\\Temp\\TestMovie.tasproj")]
public void GetNewFileNameFromBk2(string original, string expected) public void ConvertFileNameToTasMovie(string original, string expected)
{ {
var actual = MovieConversionExtensions.GetNewFileName(original); var actual = MovieConversionExtensions.ConvertFileNameToTasMovie(original);
Assert.AreEqual(expected, actual); Assert.AreEqual(expected, actual);
} }
} }