From 83033215866f55c289770b0a6dd1d6e103aafdd0 Mon Sep 17 00:00:00 2001 From: adelikat Date: Fri, 5 Jun 2020 19:26:26 -0500 Subject: [PATCH] rename method to try to better describe what it does --- .../movie/MovieConversionExtensions.cs | 8 ++++---- .../Client.Common/Movie/MovieConversionExtensionTests.cs | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/BizHawk.Client.Common/movie/MovieConversionExtensions.cs b/src/BizHawk.Client.Common/movie/MovieConversionExtensions.cs index 3be87820e6..e596674d28 100644 --- a/src/BizHawk.Client.Common/movie/MovieConversionExtensions.cs +++ b/src/BizHawk.Client.Common/movie/MovieConversionExtensions.cs @@ -17,7 +17,7 @@ namespace BizHawk.Client.Common.MovieConversionExtensions { public static ITasMovie ToTasMovie(this IMovie old) { - string newFilename = GetNewFileName(old.Filename); + string newFilename = ConvertFileNameToTasMovie(old.Filename); var tas = (ITasMovie)MovieService.Get(newFilename); tas.CopyLog(old.GetLogEntries()); @@ -85,7 +85,7 @@ namespace BizHawk.Client.Common.MovieConversionExtensions public static ITasMovie ConvertToSavestateAnchoredMovie(this ITasMovie old, int frame, byte[] savestate) { - string newFilename = GetNewFileName(old.Filename); + string newFilename = ConvertFileNameToTasMovie(old.Filename); var tas = (ITasMovie)MovieService.Get(newFilename); tas.BinarySavestate = savestate; @@ -142,7 +142,7 @@ namespace BizHawk.Client.Common.MovieConversionExtensions public static ITasMovie ConvertToSaveRamAnchoredMovie(this ITasMovie old, byte[] saveRam) { - string newFilename = GetNewFileName(old.Filename); + string newFilename = ConvertFileNameToTasMovie(old.Filename); var tas = (ITasMovie) MovieService.Get(newFilename); tas.SaveRam = saveRam; @@ -298,7 +298,7 @@ namespace BizHawk.Client.Common.MovieConversionExtensions .CoreName; } - public static string GetNewFileName(string oldFileName) + internal static string ConvertFileNameToTasMovie(string oldFileName) { string newFileName = Path.ChangeExtension(oldFileName, $".{TasMovie.Extension}"); int fileSuffix = 0; diff --git a/src/BizHawk.Tests/Client.Common/Movie/MovieConversionExtensionTests.cs b/src/BizHawk.Tests/Client.Common/Movie/MovieConversionExtensionTests.cs index d4b1e0698b..96b913567c 100644 --- a/src/BizHawk.Tests/Client.Common/Movie/MovieConversionExtensionTests.cs +++ b/src/BizHawk.Tests/Client.Common/Movie/MovieConversionExtensionTests.cs @@ -12,9 +12,9 @@ namespace BizHawk.Common.Tests.Client.Common.Movie [DataRow("C:\\Temp\\TestMovie.bk2", "C:\\Temp\\TestMovie.tasproj")] [DataRow("C:\\Temp\\TestMovie.tasproj.bk2", "C:\\Temp\\TestMovie.tasproj.tasproj")] [DataRow("C:\\Temp\\TestMovie.tasproj", "C:\\Temp\\TestMovie.tasproj")] - public void GetNewFileNameFromBk2(string original, string expected) + public void ConvertFileNameToTasMovie(string original, string expected) { - var actual = MovieConversionExtensions.GetNewFileName(original); + var actual = MovieConversionExtensions.ConvertFileNameToTasMovie(original); Assert.AreEqual(expected, actual); } }