ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Be consistent with `SignExtendAsNeeded` in `CompareSpecificValue` 

not sure why it's applied to the pivot value here but not in
`CompareDifference`, frankly I'm not sure what it actually does
This commit is contained in:
YoshiRulz 2024-05-31 13:07:33 +10:00
parent 46584cee10
commit 72a7df1227
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/BizHawk.Client.Common/tools/RamSearchEngine/RamSearchEngine.cs
View File

@ -445,8 +445,12 @@ namespace BizHawk.Client.Common.RamSearchEngine
return watchList.Where(w => SignExtendAsNeeded(GetValue(w.Address)) <= SignExtendAsNeeded(compareValue)); return watchList.Where(w => SignExtendAsNeeded(GetValue(w.Address)) <= SignExtendAsNeeded(compareValue));
case ComparisonOperator.DifferentBy: case ComparisonOperator.DifferentBy:
if (DifferentBy is not int differentBy) throw new InvalidOperationException(); if (DifferentBy is not int differentBy) throw new InvalidOperationException();
return watchList.Where(w => SignExtendAsNeeded(GetValue(w.Address)) + differentBy == compareValue return watchList.Where(w =>
|| SignExtendAsNeeded(GetValue(w.Address)) - differentBy == compareValue); {
var val = SignExtendAsNeeded(GetValue(w.Address));
var pivot = SignExtendAsNeeded(compareValue);
return val + differentBy == pivot || val - differentBy == pivot;
});
} }
} }
var compareValueF = ReinterpretAsF32(compareValue); var compareValueF = ReinterpretAsF32(compareValue);