From 72a7df1227efdc11fa467e37f7645f02c03615b4 Mon Sep 17 00:00:00 2001 From: YoshiRulz Date: Fri, 31 May 2024 13:07:33 +1000 Subject: [PATCH] Be consistent with `SignExtendAsNeeded` in `CompareSpecificValue` not sure why it's applied to the pivot value here but not in `CompareDifference`, frankly I'm not sure what it actually does --- .../tools/RamSearchEngine/RamSearchEngine.cs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/BizHawk.Client.Common/tools/RamSearchEngine/RamSearchEngine.cs b/src/BizHawk.Client.Common/tools/RamSearchEngine/RamSearchEngine.cs index 8656199d55..b781f35d20 100644 --- a/src/BizHawk.Client.Common/tools/RamSearchEngine/RamSearchEngine.cs +++ b/src/BizHawk.Client.Common/tools/RamSearchEngine/RamSearchEngine.cs @@ -445,8 +445,12 @@ namespace BizHawk.Client.Common.RamSearchEngine return watchList.Where(w => SignExtendAsNeeded(GetValue(w.Address)) <= SignExtendAsNeeded(compareValue)); case ComparisonOperator.DifferentBy: if (DifferentBy is not int differentBy) throw new InvalidOperationException(); - return watchList.Where(w => SignExtendAsNeeded(GetValue(w.Address)) + differentBy == compareValue - || SignExtendAsNeeded(GetValue(w.Address)) - differentBy == compareValue); + return watchList.Where(w => + { + var val = SignExtendAsNeeded(GetValue(w.Address)); + var pivot = SignExtendAsNeeded(compareValue); + return val + differentBy == pivot || val - differentBy == pivot; + }); } } var compareValueF = ReinterpretAsF32(compareValue);