ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Minor refactor to not mutate local in `TAStudio.TasView_MouseDown`

This commit is contained in:
YoshiRulz 2022-08-24 09:42:58 +10:00
parent 352977c7ea
commit 61c34eca74
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs
View File

@ -637,16 +637,14 @@ namespace BizHawk.Client.EmuHawk
else if (ModifierKeys == Keys.Shift && ModifierKeys != Keys.Alt) else if (ModifierKeys == Keys.Shift && ModifierKeys != Keys.Alt)
{ {
if (!TasView.AnyRowsSelected) return; if (!TasView.AnyRowsSelected) return;
var firstSel = TasView.FirstSelectedRowIndex;
if (frame <= firstSel) var iFirstSelectedRow = TasView.FirstSelectedRowIndex;
{ var (firstSel, lastSel) = frame <= iFirstSelectedRow
firstSel = frame; ? (frame, iFirstSelectedRow)
frame = TasView.FirstSelectedRowIndex; : (iFirstSelectedRow, frame);
}
bool allPressed = true; bool allPressed = true;
for (int i = firstSel; i <= frame; i++) for (var i = firstSel; i <= lastSel; i++)
{ {
if (i == CurrentTasMovie.FrameCount // last movie frame can't have input, but can be selected if (i == CurrentTasMovie.FrameCount // last movie frame can't have input, but can be selected
|| !CurrentTasMovie.BoolIsPressed(i, buttonName)) || !CurrentTasMovie.BoolIsPressed(i, buttonName))
@ -655,8 +653,8 @@ namespace BizHawk.Client.EmuHawk
break; break;
} }
} }
CurrentTasMovie.SetBoolStates(firstSel, (frame - firstSel) + 1, buttonName, !allPressed); CurrentTasMovie.SetBoolStates(firstSel, lastSel - firstSel + 1, buttonName, !allPressed);
_boolPaintState = CurrentTasMovie.BoolIsPressed(frame, buttonName); _boolPaintState = CurrentTasMovie.BoolIsPressed(lastSel, buttonName);
_triggerAutoRestore = true; _triggerAutoRestore = true;
RefreshDialog(); RefreshDialog();
} }