From 61c34eca7447421099ebf9c38f16292e61511544 Mon Sep 17 00:00:00 2001 From: YoshiRulz Date: Wed, 24 Aug 2022 09:42:58 +1000 Subject: [PATCH] Minor refactor to not mutate local in `TAStudio.TasView_MouseDown` --- .../tools/TAStudio/TAStudio.ListView.cs | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs b/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs index f93905e4fa..1e975f68a2 100644 --- a/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs +++ b/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs @@ -637,16 +637,14 @@ namespace BizHawk.Client.EmuHawk else if (ModifierKeys == Keys.Shift && ModifierKeys != Keys.Alt) { if (!TasView.AnyRowsSelected) return; - var firstSel = TasView.FirstSelectedRowIndex; - if (frame <= firstSel) - { - firstSel = frame; - frame = TasView.FirstSelectedRowIndex; - } + var iFirstSelectedRow = TasView.FirstSelectedRowIndex; + var (firstSel, lastSel) = frame <= iFirstSelectedRow + ? (frame, iFirstSelectedRow) + : (iFirstSelectedRow, frame); bool allPressed = true; - for (int i = firstSel; i <= frame; i++) + for (var i = firstSel; i <= lastSel; i++) { if (i == CurrentTasMovie.FrameCount // last movie frame can't have input, but can be selected || !CurrentTasMovie.BoolIsPressed(i, buttonName)) @@ -655,8 +653,8 @@ namespace BizHawk.Client.EmuHawk break; } } - CurrentTasMovie.SetBoolStates(firstSel, (frame - firstSel) + 1, buttonName, !allPressed); - _boolPaintState = CurrentTasMovie.BoolIsPressed(frame, buttonName); + CurrentTasMovie.SetBoolStates(firstSel, lastSel - firstSel + 1, buttonName, !allPressed); + _boolPaintState = CurrentTasMovie.BoolIsPressed(lastSel, buttonName); _triggerAutoRestore = true; RefreshDialog(); }