ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

If these two weird things were needed before, they don't seem to be needed now and just break things the way you'd expect them to break things. 

Passes recording undo/redo tests.
This commit is contained in:
SuuperW 2025-07-04 14:27:57 -05:00
parent c1605591d1
commit 500bdb57e2
No known key found for this signature in database
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/BizHawk.Client.Common/movie/tasproj/TasMovie.Editing.cs
View File

@ -11,13 +11,7 @@ namespace BizHawk.Client.Common
public override void RecordFrame(int frame, IController source) public override void RecordFrame(int frame, IController source)
{ {
// RetroEdit: This check is questionable; recording at frame 0 is valid and should be reversible. ChangeLog.AddGeneralUndo(frame, frame, $"Record Frame: {frame}");
// Also, frame - 1, why?
// Is the precondition compensating for frame - 1 reindexing?
if (frame != 0)
{
ChangeLog.AddGeneralUndo(frame - 1, frame - 1, $"Record Frame: {frame}");
}
SetFrameAt(frame, Bk2LogEntryGenerator.GenerateLogEntry(source)); SetFrameAt(frame, Bk2LogEntryGenerator.GenerateLogEntry(source));
@ -31,10 +25,7 @@ namespace BizHawk.Client.Common
InvalidateAfter(frame); InvalidateAfter(frame);
} }
if (frame != 0) ChangeLog.SetGeneralRedo();
{
ChangeLog.SetGeneralRedo();
}
} }
public override void Truncate(int frame) public override void Truncate(int frame)