From 500bdb57e260075d974975013221da9bebd1aa5a Mon Sep 17 00:00:00 2001 From: SuuperW Date: Fri, 4 Jul 2025 14:27:57 -0500 Subject: [PATCH] If these two weird things were needed before, they don't seem to be needed now and just break things the way you'd expect them to break things. Passes recording undo/redo tests. --- .../movie/tasproj/TasMovie.Editing.cs | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/BizHawk.Client.Common/movie/tasproj/TasMovie.Editing.cs b/src/BizHawk.Client.Common/movie/tasproj/TasMovie.Editing.cs index c8840fddb7..3ee98d54cb 100644 --- a/src/BizHawk.Client.Common/movie/tasproj/TasMovie.Editing.cs +++ b/src/BizHawk.Client.Common/movie/tasproj/TasMovie.Editing.cs @@ -11,13 +11,7 @@ namespace BizHawk.Client.Common public override void RecordFrame(int frame, IController source) { - // RetroEdit: This check is questionable; recording at frame 0 is valid and should be reversible. - // Also, frame - 1, why? - // Is the precondition compensating for frame - 1 reindexing? - if (frame != 0) - { - ChangeLog.AddGeneralUndo(frame - 1, frame - 1, $"Record Frame: {frame}"); - } + ChangeLog.AddGeneralUndo(frame, frame, $"Record Frame: {frame}"); SetFrameAt(frame, Bk2LogEntryGenerator.GenerateLogEntry(source)); @@ -31,10 +25,7 @@ namespace BizHawk.Client.Common InvalidateAfter(frame); } - if (frame != 0) - { - ChangeLog.SetGeneralRedo(); - } + ChangeLog.SetGeneralRedo(); } public override void Truncate(int frame)