ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

consolidate CorePickerStabilityTests

This commit is contained in:
Morilli 2024-11-30 23:30:08 +01:00
parent d335e5cba4
commit 320de38c5c
1 changed files with 1 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/BizHawk.Tests/Client.Common/config/CorePickerStabilityTests.cs
View File

@ -25,7 +25,7 @@ namespace BizHawk.Tests.Client.Common.config
foreach (var (appliesTo, _) in Config.CorePickerUIData)
{
Assert.IsTrue(
appliesTo.Any(multiCoreSystems.Contains),
appliesTo.All(multiCoreSystems.Contains),
appliesTo.Length is 1
? $"core picker has submenu for {appliesTo[0]}, but that system doesn't have alternate cores"
: $"core picker has submenu for {appliesTo[0]} ({string.Join("/", appliesTo)}), but none of those systems have alternate cores");
@ -45,22 +45,5 @@ namespace BizHawk.Tests.Client.Common.config
Assert.IsTrue(allCoreNames.Contains(coreName), $"core picker includes nonexistant core \"{coreName}\" under {appliesTo[0]} group");
}
}
/// <remarks>this really shouldn't be necessary</remarks>
[TestMethod]
public void AssertNoMissingSystems()
{
var allSysIDs = CoreInventory.Instance.AllCores.Keys.ToHashSet();
#if false // already covered by AssertAllChoicesInMenu
foreach (var sysID in DefaultCorePrefDict.Keys)
{
Assert.IsTrue(allSysIDs.Contains(sysID), $"a default core preference exists for {sysID}, which isn't emulated by any core");
}
#endif
foreach (var (appliesTo, _) in Config.CorePickerUIData) foreach (var sysID in appliesTo)
{
Assert.IsTrue(allSysIDs.Contains(sysID), $"core picker has choices for {sysID}, which isn't emulated by any core");
}
}
}
}