From 320de38c5cbf0bd38e8d9f5ededcfde9d2cb2c30 Mon Sep 17 00:00:00 2001 From: Morilli <35152647+Morilli@users.noreply.github.com> Date: Sat, 30 Nov 2024 23:30:08 +0100 Subject: [PATCH] consolidate CorePickerStabilityTests --- .../config/CorePickerStabilityTests.cs | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/src/BizHawk.Tests/Client.Common/config/CorePickerStabilityTests.cs b/src/BizHawk.Tests/Client.Common/config/CorePickerStabilityTests.cs index a5f4903ebd..916587f32a 100644 --- a/src/BizHawk.Tests/Client.Common/config/CorePickerStabilityTests.cs +++ b/src/BizHawk.Tests/Client.Common/config/CorePickerStabilityTests.cs @@ -25,7 +25,7 @@ namespace BizHawk.Tests.Client.Common.config foreach (var (appliesTo, _) in Config.CorePickerUIData) { Assert.IsTrue( - appliesTo.Any(multiCoreSystems.Contains), + appliesTo.All(multiCoreSystems.Contains), appliesTo.Length is 1 ? $"core picker has submenu for {appliesTo[0]}, but that system doesn't have alternate cores" : $"core picker has submenu for {appliesTo[0]} ({string.Join("/", appliesTo)}), but none of those systems have alternate cores"); @@ -45,22 +45,5 @@ namespace BizHawk.Tests.Client.Common.config Assert.IsTrue(allCoreNames.Contains(coreName), $"core picker includes nonexistant core \"{coreName}\" under {appliesTo[0]} group"); } } - - /// this really shouldn't be necessary - [TestMethod] - public void AssertNoMissingSystems() - { - var allSysIDs = CoreInventory.Instance.AllCores.Keys.ToHashSet(); -#if false // already covered by AssertAllChoicesInMenu - foreach (var sysID in DefaultCorePrefDict.Keys) - { - Assert.IsTrue(allSysIDs.Contains(sysID), $"a default core preference exists for {sysID}, which isn't emulated by any core"); - } -#endif - foreach (var (appliesTo, _) in Config.CorePickerUIData) foreach (var sysID in appliesTo) - { - Assert.IsTrue(allSysIDs.Contains(sysID), $"core picker has choices for {sysID}, which isn't emulated by any core"); - } - } } }