ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix default arguments in `override`s which don't match the declaration 

not enabling the relevant Analyzer rule MA0061 since that also triggers
when the override omits the default argument
This commit is contained in:
YoshiRulz 2024-07-04 06:43:24 +10:00
parent 1f7d75b7d2
commit 1c302e56db
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/BizHawk.Client.Common/Api/Classes/MemoryApi.cs
View File

@ -188,7 +188,8 @@ namespace BizHawk.Client.Common
public IReadOnlyCollection<string> GetMemoryDomainList() public IReadOnlyCollection<string> GetMemoryDomainList()
=> DomainList.Select(static domain => domain.Name).ToList(); => DomainList.Select(static domain => domain.Name).ToList();
public uint GetMemoryDomainSize(string name = null) => (uint) NamedDomainOrCurrent(name).Size; public uint GetMemoryDomainSize(string name)
=> (uint) NamedDomainOrCurrent(name).Size;
public string GetCurrentMemoryDomain() => Domain.Name; public string GetCurrentMemoryDomain() => Domain.Name;

2
src/BizHawk.Client.Common/Api/Classes/MovieApi.cs
View File

@ -55,7 +55,7 @@ namespace BizHawk.Client.Common
return lg.GenerateLogEntry(); return lg.GenerateLogEntry();
} }
public void Save(string filename = null) public void Save(string filename)
{ {
if (_movieSession.Movie.NotActive()) if (_movieSession.Movie.NotActive())
{ {

4
src/BizHawk.Client.Common/Api/Classes/SQLiteApi.cs
View File

@ -51,7 +51,7 @@ namespace BizHawk.Client.Common
return "Database Opened Successfully"; return "Database Opened Successfully";
} }
public string WriteCommand(string query = null) public string WriteCommand(string query)
{ {
if (string.IsNullOrWhiteSpace(query)) return "query is empty"; if (string.IsNullOrWhiteSpace(query)) return "query is empty";
if (_dbConnection == null) return "Database not open."; if (_dbConnection == null) return "Database not open.";
@ -71,7 +71,7 @@ namespace BizHawk.Client.Common
return result; return result;
} }
public object ReadCommand(string query = null) public object ReadCommand(string query)
{ {
if (string.IsNullOrWhiteSpace(query)) return "query is empty"; if (string.IsNullOrWhiteSpace(query)) return "query is empty";
if (_dbConnection == null) return "Database not open."; if (_dbConnection == null) return "Database not open.";