From 1c302e56db33358666ac4c4b51e45bab2ba3c6bb Mon Sep 17 00:00:00 2001 From: YoshiRulz Date: Thu, 4 Jul 2024 06:43:24 +1000 Subject: [PATCH] Fix default arguments in `override`s which don't match the declaration not enabling the relevant Analyzer rule MA0061 since that also triggers when the override omits the default argument --- src/BizHawk.Client.Common/Api/Classes/MemoryApi.cs | 3 ++- src/BizHawk.Client.Common/Api/Classes/MovieApi.cs | 2 +- src/BizHawk.Client.Common/Api/Classes/SQLiteApi.cs | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/BizHawk.Client.Common/Api/Classes/MemoryApi.cs b/src/BizHawk.Client.Common/Api/Classes/MemoryApi.cs index 5f9e6af7f6..f20daba70a 100644 --- a/src/BizHawk.Client.Common/Api/Classes/MemoryApi.cs +++ b/src/BizHawk.Client.Common/Api/Classes/MemoryApi.cs @@ -188,7 +188,8 @@ namespace BizHawk.Client.Common public IReadOnlyCollection GetMemoryDomainList() => DomainList.Select(static domain => domain.Name).ToList(); - public uint GetMemoryDomainSize(string name = null) => (uint) NamedDomainOrCurrent(name).Size; + public uint GetMemoryDomainSize(string name) + => (uint) NamedDomainOrCurrent(name).Size; public string GetCurrentMemoryDomain() => Domain.Name; diff --git a/src/BizHawk.Client.Common/Api/Classes/MovieApi.cs b/src/BizHawk.Client.Common/Api/Classes/MovieApi.cs index 92d1208a32..5665a52c7d 100644 --- a/src/BizHawk.Client.Common/Api/Classes/MovieApi.cs +++ b/src/BizHawk.Client.Common/Api/Classes/MovieApi.cs @@ -55,7 +55,7 @@ namespace BizHawk.Client.Common return lg.GenerateLogEntry(); } - public void Save(string filename = null) + public void Save(string filename) { if (_movieSession.Movie.NotActive()) { diff --git a/src/BizHawk.Client.Common/Api/Classes/SQLiteApi.cs b/src/BizHawk.Client.Common/Api/Classes/SQLiteApi.cs index 6bb6ccdbcf..215e077758 100644 --- a/src/BizHawk.Client.Common/Api/Classes/SQLiteApi.cs +++ b/src/BizHawk.Client.Common/Api/Classes/SQLiteApi.cs @@ -51,7 +51,7 @@ namespace BizHawk.Client.Common return "Database Opened Successfully"; } - public string WriteCommand(string query = null) + public string WriteCommand(string query) { if (string.IsNullOrWhiteSpace(query)) return "query is empty"; if (_dbConnection == null) return "Database not open."; @@ -71,7 +71,7 @@ namespace BizHawk.Client.Common return result; } - public object ReadCommand(string query = null) + public object ReadCommand(string query) { if (string.IsNullOrWhiteSpace(query)) return "query is empty"; if (_dbConnection == null) return "Database not open.";