Enable SA1205 and fix non-compliance (except in Cores)
"Partial elements should declare access" (type decl. modifier not copied across all parts)
This commit is contained in:
parent
5488c80f4d
commit
0dd89de0d8
|
@ -392,9 +392,6 @@
|
||||||
<!-- Static elements should appear before instance elements -->
|
<!-- Static elements should appear before instance elements -->
|
||||||
<Rule Id="SA1204" Action="Hidden" />
|
<Rule Id="SA1204" Action="Hidden" />
|
||||||
|
|
||||||
<!-- Partial elements should declare access -->
|
|
||||||
<Rule Id="SA1205" Action="Hidden" />
|
|
||||||
|
|
||||||
<!-- System using directives should be placed before other using directives -->
|
<!-- System using directives should be placed before other using directives -->
|
||||||
<Rule Id="SA1208" Action="Hidden" />
|
<Rule Id="SA1208" Action="Hidden" />
|
||||||
|
|
||||||
|
|
|
@ -10,7 +10,7 @@ using BizHawk.Client.Common;
|
||||||
|
|
||||||
namespace BizHawk.Client.EmuHawk
|
namespace BizHawk.Client.EmuHawk
|
||||||
{
|
{
|
||||||
partial class MainForm
|
public partial class MainForm
|
||||||
{
|
{
|
||||||
private enum LoadOrdering
|
private enum LoadOrdering
|
||||||
{
|
{
|
||||||
|
|
|
@ -7,7 +7,7 @@ using BizHawk.Emulation.Common;
|
||||||
|
|
||||||
namespace BizHawk.Client.EmuHawk
|
namespace BizHawk.Client.EmuHawk
|
||||||
{
|
{
|
||||||
partial class MainForm
|
public partial class MainForm
|
||||||
{
|
{
|
||||||
public bool StartNewMovie(IMovie movie, bool record)
|
public bool StartNewMovie(IMovie movie, bool record)
|
||||||
{
|
{
|
||||||
|
|
|
@ -2,7 +2,7 @@
|
||||||
<Import Project="../MainSlnCommon.props" />
|
<Import Project="../MainSlnCommon.props" />
|
||||||
<PropertyGroup>
|
<PropertyGroup>
|
||||||
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
|
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
|
||||||
<NoWarn>$(NoWarn);SA1400</NoWarn>
|
<NoWarn>$(NoWarn);SA1205;SA1400</NoWarn>
|
||||||
<TargetFramework>netstandard2.0</TargetFramework>
|
<TargetFramework>netstandard2.0</TargetFramework>
|
||||||
</PropertyGroup>
|
</PropertyGroup>
|
||||||
<ItemGroup>
|
<ItemGroup>
|
||||||
|
|
|
@ -16,7 +16,7 @@ using System.Collections.Generic;
|
||||||
|
|
||||||
namespace BizHawk.Emulation.DiscSystem
|
namespace BizHawk.Emulation.DiscSystem
|
||||||
{
|
{
|
||||||
public partial class Disc : IDisposable
|
public sealed partial class Disc : IDisposable
|
||||||
{
|
{
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Automagically loads a disc, without any fine-tuned control at all
|
/// Automagically loads a disc, without any fine-tuned control at all
|
||||||
|
|
|
@ -32,7 +32,7 @@ using BizHawk.Common.NumberExtensions;
|
||||||
|
|
||||||
namespace BizHawk.Emulation.DiscSystem
|
namespace BizHawk.Emulation.DiscSystem
|
||||||
{
|
{
|
||||||
sealed partial class Disc
|
public sealed partial class Disc
|
||||||
{
|
{
|
||||||
internal class Blob_ECM : IBlob
|
internal class Blob_ECM : IBlob
|
||||||
{
|
{
|
||||||
|
|
|
@ -2,7 +2,7 @@
|
||||||
|
|
||||||
namespace BizHawk.Emulation.DiscSystem
|
namespace BizHawk.Emulation.DiscSystem
|
||||||
{
|
{
|
||||||
partial class Disc
|
public sealed partial class Disc
|
||||||
{
|
{
|
||||||
internal class Blob_RawFile : IBlob
|
internal class Blob_RawFile : IBlob
|
||||||
{
|
{
|
||||||
|
|
|
@ -4,7 +4,7 @@ using System.IO;
|
||||||
|
|
||||||
namespace BizHawk.Emulation.DiscSystem
|
namespace BizHawk.Emulation.DiscSystem
|
||||||
{
|
{
|
||||||
partial class Disc
|
public sealed partial class Disc
|
||||||
{
|
{
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// TODO - double-check that riffmaster is not filling memory at load-time but reading through to the disk
|
/// TODO - double-check that riffmaster is not filling memory at load-time but reading through to the disk
|
||||||
|
|
|
@ -4,7 +4,7 @@ using System;
|
||||||
|
|
||||||
namespace BizHawk.Emulation.DiscSystem
|
namespace BizHawk.Emulation.DiscSystem
|
||||||
{
|
{
|
||||||
public partial class Disc : IDisposable
|
public sealed partial class Disc : IDisposable
|
||||||
{
|
{
|
||||||
internal sealed class Blob_ZeroPadAdapter : IBlob
|
internal sealed class Blob_ZeroPadAdapter : IBlob
|
||||||
{
|
{
|
||||||
|
|
|
@ -1,6 +1,6 @@
|
||||||
namespace BizHawk.Emulation.DiscSystem
|
namespace BizHawk.Emulation.DiscSystem
|
||||||
{
|
{
|
||||||
partial class DiscMountJob
|
public partial class DiscMountJob
|
||||||
{
|
{
|
||||||
private class SS_MednaDisc : ISectorSynthJob2448
|
private class SS_MednaDisc : ISectorSynthJob2448
|
||||||
{
|
{
|
||||||
|
|
Loading…
Reference in New Issue