From 0dd89de0d85f55501b2d527bcb1cee9e60a97d95 Mon Sep 17 00:00:00 2001
From: YoshiRulz <OSSYoshiRulz@gmail.com>
Date: Tue, 8 Sep 2020 22:09:37 +1000
Subject: [PATCH] Enable SA1205 and fix non-compliance (except in Cores)

"Partial elements should declare access" (type decl. modifier not copied across
all parts)
---
 Common.ruleset                                                 | 3 ---
 src/BizHawk.Client.EmuHawk/MainForm.FileLoader.cs              | 2 +-
 src/BizHawk.Client.EmuHawk/MainForm.Movie.cs                   | 2 +-
 src/BizHawk.Emulation.Cores/BizHawk.Emulation.Cores.csproj     | 2 +-
 src/BizHawk.Emulation.DiscSystem/Disc.cs                       | 2 +-
 src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_ECM.cs | 2 +-
 .../DiscFormats/Blobs/Blob_RawFile.cs                          | 2 +-
 .../DiscFormats/Blobs/Blob_WaveFile.cs                         | 2 +-
 .../DiscFormats/Blobs/Blob_ZeroPadAdapter.cs                   | 2 +-
 src/BizHawk.Emulation.DiscSystem/DiscMountJob.MednaDisc.cs     | 2 +-
 10 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/Common.ruleset b/Common.ruleset
index 6a454aeaf8..78ea089945 100644
--- a/Common.ruleset
+++ b/Common.ruleset
@@ -392,9 +392,6 @@
 		<!-- Static elements should appear before instance elements -->
 		<Rule Id="SA1204" Action="Hidden" />
 
-		<!-- Partial elements should declare access -->
-		<Rule Id="SA1205" Action="Hidden" />
-
 		<!-- System using directives should be placed before other using directives -->
 		<Rule Id="SA1208" Action="Hidden" />
 
diff --git a/src/BizHawk.Client.EmuHawk/MainForm.FileLoader.cs b/src/BizHawk.Client.EmuHawk/MainForm.FileLoader.cs
index efbbb4db3d..3ab451bcb2 100644
--- a/src/BizHawk.Client.EmuHawk/MainForm.FileLoader.cs
+++ b/src/BizHawk.Client.EmuHawk/MainForm.FileLoader.cs
@@ -10,7 +10,7 @@ using BizHawk.Client.Common;
 
 namespace BizHawk.Client.EmuHawk
 {
-	partial class MainForm
+	public partial class MainForm
 	{
 		private enum LoadOrdering
 		{
diff --git a/src/BizHawk.Client.EmuHawk/MainForm.Movie.cs b/src/BizHawk.Client.EmuHawk/MainForm.Movie.cs
index 795f9105fc..12afcad72b 100644
--- a/src/BizHawk.Client.EmuHawk/MainForm.Movie.cs
+++ b/src/BizHawk.Client.EmuHawk/MainForm.Movie.cs
@@ -7,7 +7,7 @@ using BizHawk.Emulation.Common;
 
 namespace BizHawk.Client.EmuHawk
 {
-	partial class MainForm
+	public partial class MainForm
 	{
 		public bool StartNewMovie(IMovie movie, bool record)
 		{
diff --git a/src/BizHawk.Emulation.Cores/BizHawk.Emulation.Cores.csproj b/src/BizHawk.Emulation.Cores/BizHawk.Emulation.Cores.csproj
index e1ea18ca17..281736e971 100644
--- a/src/BizHawk.Emulation.Cores/BizHawk.Emulation.Cores.csproj
+++ b/src/BizHawk.Emulation.Cores/BizHawk.Emulation.Cores.csproj
@@ -2,7 +2,7 @@
 	<Import Project="../MainSlnCommon.props" />
 	<PropertyGroup>
 		<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
-		<NoWarn>$(NoWarn);SA1400</NoWarn>
+		<NoWarn>$(NoWarn);SA1205;SA1400</NoWarn>
 		<TargetFramework>netstandard2.0</TargetFramework>
 	</PropertyGroup>
 	<ItemGroup>
diff --git a/src/BizHawk.Emulation.DiscSystem/Disc.cs b/src/BizHawk.Emulation.DiscSystem/Disc.cs
index d7af67ddf8..2d0642b80a 100644
--- a/src/BizHawk.Emulation.DiscSystem/Disc.cs
+++ b/src/BizHawk.Emulation.DiscSystem/Disc.cs
@@ -16,7 +16,7 @@ using System.Collections.Generic;
 
 namespace BizHawk.Emulation.DiscSystem
 {
-	public partial class Disc : IDisposable
+	public sealed partial class Disc : IDisposable
 	{
 		/// <summary>
 		/// Automagically loads a disc, without any fine-tuned control at all
diff --git a/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_ECM.cs b/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_ECM.cs
index 4dc18f0f9d..dcef4d38af 100644
--- a/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_ECM.cs
+++ b/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_ECM.cs
@@ -32,7 +32,7 @@ using BizHawk.Common.NumberExtensions;
 
 namespace BizHawk.Emulation.DiscSystem
 {
-	sealed partial class Disc
+	public sealed partial class Disc
 	{
 		internal class Blob_ECM : IBlob
 		{
diff --git a/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_RawFile.cs b/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_RawFile.cs
index 5bbe58f8b6..32db63b5c2 100644
--- a/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_RawFile.cs
+++ b/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_RawFile.cs
@@ -2,7 +2,7 @@
 
 namespace BizHawk.Emulation.DiscSystem
 {
-	partial class Disc
+	public sealed partial class Disc
 	{
 		internal class Blob_RawFile : IBlob
 		{
diff --git a/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_WaveFile.cs b/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_WaveFile.cs
index 2a8cd1ab7d..90c147b8a7 100644
--- a/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_WaveFile.cs
+++ b/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_WaveFile.cs
@@ -4,7 +4,7 @@ using System.IO;
 
 namespace BizHawk.Emulation.DiscSystem
 {
-	partial class Disc
+	public sealed partial class Disc
 	{
 		/// <summary>
 		/// TODO - double-check that riffmaster is not filling memory at load-time but reading through to the disk
diff --git a/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_ZeroPadAdapter.cs b/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_ZeroPadAdapter.cs
index 39b195c2d9..0807d3b5d1 100644
--- a/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_ZeroPadAdapter.cs
+++ b/src/BizHawk.Emulation.DiscSystem/DiscFormats/Blobs/Blob_ZeroPadAdapter.cs
@@ -4,7 +4,7 @@ using System;
 
 namespace BizHawk.Emulation.DiscSystem
 {
-	public partial class Disc : IDisposable
+	public sealed partial class Disc : IDisposable
 	{
 		internal sealed class Blob_ZeroPadAdapter : IBlob
 		{
diff --git a/src/BizHawk.Emulation.DiscSystem/DiscMountJob.MednaDisc.cs b/src/BizHawk.Emulation.DiscSystem/DiscMountJob.MednaDisc.cs
index 881b160ade..645cd101ab 100644
--- a/src/BizHawk.Emulation.DiscSystem/DiscMountJob.MednaDisc.cs
+++ b/src/BizHawk.Emulation.DiscSystem/DiscMountJob.MednaDisc.cs
@@ -1,6 +1,6 @@
 namespace BizHawk.Emulation.DiscSystem
 {
-	partial class DiscMountJob
+	public partial class DiscMountJob
 	{
 		private class SS_MednaDisc : ISectorSynthJob2448
 		{