hipnosuer
/
Zuma
forked from ShuriZma/suyu
1
0
Fork 0
Code Pull Requests Activity

Pica: Write depth value even when depth test is disabled 

This has been confirmed on hardware. Fixes Etrian Odyssey IV.
This commit is contained in:
Yuri Kunde Schlesner 2016-03-05 14:18:20 -08:00
parent b5ca152389
commit c58bc25d5b
2 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/video_core/rasterizer.cpp
View File

@ -858,12 +858,12 @@ static void ProcessTriangleInternal(const Shader::OutputVertex& v0,
} }
} }
// TODO: Does depth indeed only get written even if depth testing is enabled?
if (output_merger.depth_test_enable) {
unsigned num_bits = Regs::DepthBitsPerPixel(regs.framebuffer.depth_format); unsigned num_bits = Regs::DepthBitsPerPixel(regs.framebuffer.depth_format);
u32 z = (u32)((v0.screenpos[2].ToFloat32() * w0 + u32 z = (u32)((v0.screenpos[2].ToFloat32() * w0 +
v1.screenpos[2].ToFloat32() * w1 + v1.screenpos[2].ToFloat32() * w1 +
v2.screenpos[2].ToFloat32() * w2) * ((1 << num_bits) - 1) / wsum); v2.screenpos[2].ToFloat32() * w2) * ((1 << num_bits) - 1) / wsum);
if (output_merger.depth_test_enable) {
u32 ref_z = GetDepth(x >> 4, y >> 4); u32 ref_z = GetDepth(x >> 4, y >> 4);
bool pass = false; bool pass = false;
@ -907,10 +907,10 @@ static void ProcessTriangleInternal(const Shader::OutputVertex& v0,
UpdateStencil(stencil_test.action_depth_fail); UpdateStencil(stencil_test.action_depth_fail);
continue; continue;
} }
}
if (output_merger.depth_write_enable) if (output_merger.depth_write_enable)
SetDepth(x >> 4, y >> 4, z); SetDepth(x >> 4, y >> 4, z);
}
// The stencil depth_pass action is executed even if depth testing is disabled // The stencil depth_pass action is executed even if depth testing is disabled
if (stencil_action_enable) if (stencil_action_enable)

6
src/video_core/renderer_opengl/gl_rasterizer.cpp
View File

@ -887,8 +887,10 @@ void RasterizerOpenGL::SyncStencilTest() {
void RasterizerOpenGL::SyncDepthTest() { void RasterizerOpenGL::SyncDepthTest() {
const auto& regs = Pica::g_state.regs; const auto& regs = Pica::g_state.regs;
state.depth.test_enabled = (regs.output_merger.depth_test_enable == 1); state.depth.test_enabled = regs.output_merger.depth_test_enable == 1 ||
state.depth.test_func = PicaToGL::CompareFunc(regs.output_merger.depth_test_func); regs.output_merger.depth_write_enable == 1;
state.depth.test_func = regs.output_merger.depth_test_enable == 1 ?
PicaToGL::CompareFunc(regs.output_merger.depth_test_func) : GL_ALWAYS;
state.color_mask.red_enabled = regs.output_merger.red_enable; state.color_mask.red_enabled = regs.output_merger.red_enable;
state.color_mask.green_enabled = regs.output_merger.green_enable; state.color_mask.green_enabled = regs.output_merger.green_enable;
state.color_mask.blue_enabled = regs.output_merger.blue_enable; state.color_mask.blue_enabled = regs.output_merger.blue_enable;