forked from ShuriZma/suyu
kernel: Don't fail silently
This commit is contained in:
parent
8e64fb3225
commit
b6538c3e7c
|
@ -30,6 +30,7 @@ HandleTable::~HandleTable() = default;
|
||||||
|
|
||||||
ResultCode HandleTable::SetSize(s32 handle_table_size) {
|
ResultCode HandleTable::SetSize(s32 handle_table_size) {
|
||||||
if (static_cast<u32>(handle_table_size) > MAX_COUNT) {
|
if (static_cast<u32>(handle_table_size) > MAX_COUNT) {
|
||||||
|
LOG_ERROR(Kernel, "Handle table size {} is greater than {}", handle_table_size, MAX_COUNT);
|
||||||
return ERR_OUT_OF_MEMORY;
|
return ERR_OUT_OF_MEMORY;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -80,6 +81,7 @@ ResultVal<Handle> HandleTable::Duplicate(Handle handle) {
|
||||||
|
|
||||||
ResultCode HandleTable::Close(Handle handle) {
|
ResultCode HandleTable::Close(Handle handle) {
|
||||||
if (!IsValid(handle)) {
|
if (!IsValid(handle)) {
|
||||||
|
LOG_ERROR(Kernel, "Handle is not valid! handle={:08X}", handle);
|
||||||
return ERR_INVALID_HANDLE;
|
return ERR_INVALID_HANDLE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -7,6 +7,7 @@
|
||||||
#include <vector>
|
#include <vector>
|
||||||
|
|
||||||
#include "common/assert.h"
|
#include "common/assert.h"
|
||||||
|
#include "common/logging/log.h"
|
||||||
#include "core/core.h"
|
#include "core/core.h"
|
||||||
#include "core/hle/kernel/errors.h"
|
#include "core/hle/kernel/errors.h"
|
||||||
#include "core/hle/kernel/handle_table.h"
|
#include "core/hle/kernel/handle_table.h"
|
||||||
|
@ -67,6 +68,7 @@ ResultCode Mutex::TryAcquire(VAddr address, Handle holding_thread_handle,
|
||||||
Handle requesting_thread_handle) {
|
Handle requesting_thread_handle) {
|
||||||
// The mutex address must be 4-byte aligned
|
// The mutex address must be 4-byte aligned
|
||||||
if ((address % sizeof(u32)) != 0) {
|
if ((address % sizeof(u32)) != 0) {
|
||||||
|
LOG_ERROR(Kernel, "Address is not 4-byte aligned! address={:016X}", address);
|
||||||
return ERR_INVALID_ADDRESS;
|
return ERR_INVALID_ADDRESS;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -88,6 +90,8 @@ ResultCode Mutex::TryAcquire(VAddr address, Handle holding_thread_handle,
|
||||||
}
|
}
|
||||||
|
|
||||||
if (holding_thread == nullptr) {
|
if (holding_thread == nullptr) {
|
||||||
|
LOG_ERROR(Kernel, "Holding thread does not exist! thread_handle={:08X}",
|
||||||
|
holding_thread_handle);
|
||||||
return ERR_INVALID_HANDLE;
|
return ERR_INVALID_HANDLE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -109,6 +113,7 @@ ResultCode Mutex::TryAcquire(VAddr address, Handle holding_thread_handle,
|
||||||
ResultCode Mutex::Release(VAddr address) {
|
ResultCode Mutex::Release(VAddr address) {
|
||||||
// The mutex address must be 4-byte aligned
|
// The mutex address must be 4-byte aligned
|
||||||
if ((address % sizeof(u32)) != 0) {
|
if ((address % sizeof(u32)) != 0) {
|
||||||
|
LOG_ERROR(Kernel, "Address is not 4-byte aligned! address={:016X}", address);
|
||||||
return ERR_INVALID_ADDRESS;
|
return ERR_INVALID_ADDRESS;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -3,6 +3,7 @@
|
||||||
// Refer to the license.txt file included.
|
// Refer to the license.txt file included.
|
||||||
|
|
||||||
#include "common/bit_util.h"
|
#include "common/bit_util.h"
|
||||||
|
#include "common/logging/log.h"
|
||||||
#include "core/hle/kernel/errors.h"
|
#include "core/hle/kernel/errors.h"
|
||||||
#include "core/hle/kernel/handle_table.h"
|
#include "core/hle/kernel/handle_table.h"
|
||||||
#include "core/hle/kernel/memory/page_table.h"
|
#include "core/hle/kernel/memory/page_table.h"
|
||||||
|
@ -119,22 +120,30 @@ ResultCode ProcessCapabilities::ParseCapabilities(const u32* capabilities,
|
||||||
// The MapPhysical type uses two descriptor flags for its parameters.
|
// The MapPhysical type uses two descriptor flags for its parameters.
|
||||||
// If there's only one, then there's a problem.
|
// If there's only one, then there's a problem.
|
||||||
if (i >= num_capabilities) {
|
if (i >= num_capabilities) {
|
||||||
|
LOG_ERROR(Kernel, "Invalid combination! i={}", i);
|
||||||
return ERR_INVALID_COMBINATION;
|
return ERR_INVALID_COMBINATION;
|
||||||
}
|
}
|
||||||
|
|
||||||
const auto size_flags = capabilities[i];
|
const auto size_flags = capabilities[i];
|
||||||
if (GetCapabilityType(size_flags) != CapabilityType::MapPhysical) {
|
if (GetCapabilityType(size_flags) != CapabilityType::MapPhysical) {
|
||||||
|
LOG_ERROR(Kernel, "Invalid capability type! size_flags={}", size_flags);
|
||||||
return ERR_INVALID_COMBINATION;
|
return ERR_INVALID_COMBINATION;
|
||||||
}
|
}
|
||||||
|
|
||||||
const auto result = HandleMapPhysicalFlags(descriptor, size_flags, page_table);
|
const auto result = HandleMapPhysicalFlags(descriptor, size_flags, page_table);
|
||||||
if (result.IsError()) {
|
if (result.IsError()) {
|
||||||
|
LOG_ERROR(Kernel, "Failed to map physical flags! descriptor={}, size_flags={}",
|
||||||
|
descriptor, size_flags);
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
const auto result =
|
const auto result =
|
||||||
ParseSingleFlagCapability(set_flags, set_svc_bits, descriptor, page_table);
|
ParseSingleFlagCapability(set_flags, set_svc_bits, descriptor, page_table);
|
||||||
if (result.IsError()) {
|
if (result.IsError()) {
|
||||||
|
LOG_ERROR(
|
||||||
|
Kernel,
|
||||||
|
"Failed to parse capability flag! set_flags={}, set_svc_bits={}, descriptor={}",
|
||||||
|
set_flags, set_svc_bits, descriptor);
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -162,6 +171,9 @@ ResultCode ProcessCapabilities::ParseSingleFlagCapability(u32& set_flags, u32& s
|
||||||
const u32 flag_length = GetFlagBitOffset(type);
|
const u32 flag_length = GetFlagBitOffset(type);
|
||||||
const u32 set_flag = 1U << flag_length;
|
const u32 set_flag = 1U << flag_length;
|
||||||
if ((set_flag & set_flags & InitializeOnceMask) != 0) {
|
if ((set_flag & set_flags & InitializeOnceMask) != 0) {
|
||||||
|
LOG_ERROR(Kernel,
|
||||||
|
"Attempted to initialize flags that may only be initialized once. set_flags={}",
|
||||||
|
set_flags);
|
||||||
return ERR_INVALID_COMBINATION;
|
return ERR_INVALID_COMBINATION;
|
||||||
}
|
}
|
||||||
set_flags |= set_flag;
|
set_flags |= set_flag;
|
||||||
|
@ -187,6 +199,7 @@ ResultCode ProcessCapabilities::ParseSingleFlagCapability(u32& set_flags, u32& s
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
LOG_ERROR(Kernel, "Invalid capability type! type={}", static_cast<u32>(type));
|
||||||
return ERR_INVALID_CAPABILITY_DESCRIPTOR;
|
return ERR_INVALID_CAPABILITY_DESCRIPTOR;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -208,23 +221,31 @@ void ProcessCapabilities::Clear() {
|
||||||
|
|
||||||
ResultCode ProcessCapabilities::HandlePriorityCoreNumFlags(u32 flags) {
|
ResultCode ProcessCapabilities::HandlePriorityCoreNumFlags(u32 flags) {
|
||||||
if (priority_mask != 0 || core_mask != 0) {
|
if (priority_mask != 0 || core_mask != 0) {
|
||||||
|
LOG_ERROR(Kernel, "Core or priority mask are not zero! priority_mask={}, core_mask={}",
|
||||||
|
priority_mask, core_mask);
|
||||||
return ERR_INVALID_CAPABILITY_DESCRIPTOR;
|
return ERR_INVALID_CAPABILITY_DESCRIPTOR;
|
||||||
}
|
}
|
||||||
|
|
||||||
const u32 core_num_min = (flags >> 16) & 0xFF;
|
const u32 core_num_min = (flags >> 16) & 0xFF;
|
||||||
const u32 core_num_max = (flags >> 24) & 0xFF;
|
const u32 core_num_max = (flags >> 24) & 0xFF;
|
||||||
if (core_num_min > core_num_max) {
|
if (core_num_min > core_num_max) {
|
||||||
|
LOG_ERROR(Kernel, "Core min is greater than core max! core_num_min={}, core_num_max={}",
|
||||||
|
core_num_min, core_num_max);
|
||||||
return ERR_INVALID_COMBINATION;
|
return ERR_INVALID_COMBINATION;
|
||||||
}
|
}
|
||||||
|
|
||||||
const u32 priority_min = (flags >> 10) & 0x3F;
|
const u32 priority_min = (flags >> 10) & 0x3F;
|
||||||
const u32 priority_max = (flags >> 4) & 0x3F;
|
const u32 priority_max = (flags >> 4) & 0x3F;
|
||||||
if (priority_min > priority_max) {
|
if (priority_min > priority_max) {
|
||||||
|
LOG_ERROR(Kernel,
|
||||||
|
"Priority min is greater than priority max! priority_min={}, priority_max={}",
|
||||||
|
core_num_min, priority_max);
|
||||||
return ERR_INVALID_COMBINATION;
|
return ERR_INVALID_COMBINATION;
|
||||||
}
|
}
|
||||||
|
|
||||||
// The switch only has 4 usable cores.
|
// The switch only has 4 usable cores.
|
||||||
if (core_num_max >= 4) {
|
if (core_num_max >= 4) {
|
||||||
|
LOG_ERROR(Kernel, "Invalid max cores specified! core_num_max={}", core_num_max);
|
||||||
return ERR_INVALID_PROCESSOR_ID;
|
return ERR_INVALID_PROCESSOR_ID;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -259,6 +280,7 @@ ResultCode ProcessCapabilities::HandleSyscallFlags(u32& set_svc_bits, u32 flags)
|
||||||
}
|
}
|
||||||
|
|
||||||
if (svc_number >= svc_capabilities.size()) {
|
if (svc_number >= svc_capabilities.size()) {
|
||||||
|
LOG_ERROR(Kernel, "Process svc capability is out of range! svc_number={}", svc_number);
|
||||||
return ERR_OUT_OF_RANGE;
|
return ERR_OUT_OF_RANGE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -295,6 +317,8 @@ ResultCode ProcessCapabilities::HandleInterruptFlags(u32 flags) {
|
||||||
// emulate that, it's sufficient to mark every interrupt as defined.
|
// emulate that, it's sufficient to mark every interrupt as defined.
|
||||||
|
|
||||||
if (interrupt >= interrupt_capabilities.size()) {
|
if (interrupt >= interrupt_capabilities.size()) {
|
||||||
|
LOG_ERROR(Kernel, "Process interrupt capability is out of range! svc_number={}",
|
||||||
|
interrupt);
|
||||||
return ERR_OUT_OF_RANGE;
|
return ERR_OUT_OF_RANGE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -307,6 +331,7 @@ ResultCode ProcessCapabilities::HandleInterruptFlags(u32 flags) {
|
||||||
ResultCode ProcessCapabilities::HandleProgramTypeFlags(u32 flags) {
|
ResultCode ProcessCapabilities::HandleProgramTypeFlags(u32 flags) {
|
||||||
const u32 reserved = flags >> 17;
|
const u32 reserved = flags >> 17;
|
||||||
if (reserved != 0) {
|
if (reserved != 0) {
|
||||||
|
LOG_ERROR(Kernel, "Reserved value is non-zero! reserved={}", reserved);
|
||||||
return ERR_RESERVED_VALUE;
|
return ERR_RESERVED_VALUE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -324,6 +349,9 @@ ResultCode ProcessCapabilities::HandleKernelVersionFlags(u32 flags) {
|
||||||
const u32 major_version = kernel_version >> 19;
|
const u32 major_version = kernel_version >> 19;
|
||||||
|
|
||||||
if (major_version != 0 || flags < 0x80000) {
|
if (major_version != 0 || flags < 0x80000) {
|
||||||
|
LOG_ERROR(Kernel,
|
||||||
|
"Kernel version is non zero or flags are too small! major_version={}, flags={}",
|
||||||
|
major_version, flags);
|
||||||
return ERR_INVALID_CAPABILITY_DESCRIPTOR;
|
return ERR_INVALID_CAPABILITY_DESCRIPTOR;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -334,6 +362,7 @@ ResultCode ProcessCapabilities::HandleKernelVersionFlags(u32 flags) {
|
||||||
ResultCode ProcessCapabilities::HandleHandleTableFlags(u32 flags) {
|
ResultCode ProcessCapabilities::HandleHandleTableFlags(u32 flags) {
|
||||||
const u32 reserved = flags >> 26;
|
const u32 reserved = flags >> 26;
|
||||||
if (reserved != 0) {
|
if (reserved != 0) {
|
||||||
|
LOG_ERROR(Kernel, "Reserved value is non-zero! reserved={}", reserved);
|
||||||
return ERR_RESERVED_VALUE;
|
return ERR_RESERVED_VALUE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -344,6 +373,7 @@ ResultCode ProcessCapabilities::HandleHandleTableFlags(u32 flags) {
|
||||||
ResultCode ProcessCapabilities::HandleDebugFlags(u32 flags) {
|
ResultCode ProcessCapabilities::HandleDebugFlags(u32 flags) {
|
||||||
const u32 reserved = flags >> 19;
|
const u32 reserved = flags >> 19;
|
||||||
if (reserved != 0) {
|
if (reserved != 0) {
|
||||||
|
LOG_ERROR(Kernel, "Reserved value is non-zero! reserved={}", reserved);
|
||||||
return ERR_RESERVED_VALUE;
|
return ERR_RESERVED_VALUE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -4,6 +4,7 @@
|
||||||
|
|
||||||
#include <algorithm>
|
#include <algorithm>
|
||||||
#include "common/assert.h"
|
#include "common/assert.h"
|
||||||
|
#include "common/logging/log.h"
|
||||||
#include "core/hle/kernel/errors.h"
|
#include "core/hle/kernel/errors.h"
|
||||||
#include "core/hle/kernel/object.h"
|
#include "core/hle/kernel/object.h"
|
||||||
#include "core/hle/kernel/readable_event.h"
|
#include "core/hle/kernel/readable_event.h"
|
||||||
|
@ -35,6 +36,8 @@ void ReadableEvent::Clear() {
|
||||||
|
|
||||||
ResultCode ReadableEvent::Reset() {
|
ResultCode ReadableEvent::Reset() {
|
||||||
if (!is_signaled) {
|
if (!is_signaled) {
|
||||||
|
LOG_ERROR(Kernel, "Handle is not signaled! object_id={}, object_type={}, object_name={}",
|
||||||
|
GetObjectId(), GetTypeName(), GetName());
|
||||||
return ERR_INVALID_STATE;
|
return ERR_INVALID_STATE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -69,6 +69,8 @@ ResultCode ResourceLimit::SetLimitValue(ResourceType resource, s64 value) {
|
||||||
limit[index] = value;
|
limit[index] = value;
|
||||||
return RESULT_SUCCESS;
|
return RESULT_SUCCESS;
|
||||||
} else {
|
} else {
|
||||||
|
LOG_ERROR(Kernel, "Limit value is too large! resource={}, value={}, index={}",
|
||||||
|
static_cast<u32>(resource), value, index);
|
||||||
return ERR_INVALID_STATE;
|
return ERR_INVALID_STATE;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -685,6 +685,8 @@ static ResultCode GetInfo(Core::System& system, u64* result, u64 info_id, u64 ha
|
||||||
case GetInfoType::TotalPhysicalMemoryAvailableWithoutSystemResource:
|
case GetInfoType::TotalPhysicalMemoryAvailableWithoutSystemResource:
|
||||||
case GetInfoType::TotalPhysicalMemoryUsedWithoutSystemResource: {
|
case GetInfoType::TotalPhysicalMemoryUsedWithoutSystemResource: {
|
||||||
if (info_sub_id != 0) {
|
if (info_sub_id != 0) {
|
||||||
|
LOG_ERROR(Kernel_SVC, "Info sub id is non zero! info_id={}, info_sub_id={}", info_id,
|
||||||
|
info_sub_id);
|
||||||
return ERR_INVALID_ENUM_VALUE;
|
return ERR_INVALID_ENUM_VALUE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -692,6 +694,8 @@ static ResultCode GetInfo(Core::System& system, u64* result, u64 info_id, u64 ha
|
||||||
system.Kernel().CurrentProcess()->GetHandleTable();
|
system.Kernel().CurrentProcess()->GetHandleTable();
|
||||||
const auto process = current_process_handle_table.Get<Process>(static_cast<Handle>(handle));
|
const auto process = current_process_handle_table.Get<Process>(static_cast<Handle>(handle));
|
||||||
if (!process) {
|
if (!process) {
|
||||||
|
LOG_ERROR(Kernel_SVC, "Process is not valid! info_id={}, info_sub_id={}, handle={:08X}",
|
||||||
|
info_id, info_sub_id, handle);
|
||||||
return ERR_INVALID_HANDLE;
|
return ERR_INVALID_HANDLE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -783,10 +787,13 @@ static ResultCode GetInfo(Core::System& system, u64* result, u64 info_id, u64 ha
|
||||||
|
|
||||||
case GetInfoType::RegisterResourceLimit: {
|
case GetInfoType::RegisterResourceLimit: {
|
||||||
if (handle != 0) {
|
if (handle != 0) {
|
||||||
|
LOG_ERROR(Kernel, "Handle is non zero! handle={:08X}", handle);
|
||||||
return ERR_INVALID_HANDLE;
|
return ERR_INVALID_HANDLE;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (info_sub_id != 0) {
|
if (info_sub_id != 0) {
|
||||||
|
LOG_ERROR(Kernel, "Info sub id is non zero! info_id={}, info_sub_id={}", info_id,
|
||||||
|
info_sub_id);
|
||||||
return ERR_INVALID_COMBINATION;
|
return ERR_INVALID_COMBINATION;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -423,6 +423,8 @@ ResultCode Thread::SetCoreAndAffinityMask(s32 new_core, u64 new_affinity_mask) {
|
||||||
if (new_core == THREADPROCESSORID_DONT_UPDATE) {
|
if (new_core == THREADPROCESSORID_DONT_UPDATE) {
|
||||||
new_core = use_override ? ideal_core_override : ideal_core;
|
new_core = use_override ? ideal_core_override : ideal_core;
|
||||||
if ((new_affinity_mask & (1ULL << new_core)) == 0) {
|
if ((new_affinity_mask & (1ULL << new_core)) == 0) {
|
||||||
|
LOG_ERROR(Kernel, "New affinity mask is incorrect! new_core={}, new_affinity_mask={}",
|
||||||
|
new_core, new_affinity_mask);
|
||||||
return ERR_INVALID_COMBINATION;
|
return ERR_INVALID_COMBINATION;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue