nseries: clean up coding style

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2014-05-12 10:03:05 +02:00
parent 7e4e88656c
commit fddbd80cc9
1 changed files with 145 additions and 127 deletions

View File

@ -239,8 +239,9 @@ static void n800_key_event(void *opaque, int keycode)
int code = s->keymap[keycode & 0x7f]; int code = s->keymap[keycode & 0x7f];
if (code == -1) { if (code == -1) {
if ((keycode & 0x7f) == RETU_KEYCODE) if ((keycode & 0x7f) == RETU_KEYCODE) {
retu_key_event(s->retu, !(keycode & 0x80)); retu_key_event(s->retu, !(keycode & 0x80));
}
return; return;
} }
@ -280,11 +281,14 @@ static void n800_tsc_kbd_setup(struct n800_s *s)
s->ts.opaque = s->ts.chip->opaque; s->ts.opaque = s->ts.chip->opaque;
s->ts.txrx = tsc210x_txrx; s->ts.txrx = tsc210x_txrx;
for (i = 0; i < 0x80; i ++) for (i = 0; i < 0x80; i++) {
s->keymap[i] = -1; s->keymap[i] = -1;
for (i = 0; i < 0x10; i ++) }
if (n800_keys[i] >= 0) for (i = 0; i < 0x10; i++) {
if (n800_keys[i] >= 0) {
s->keymap[n800_keys[i]] = i; s->keymap[n800_keys[i]] = i;
}
}
qemu_add_kbd_event_handler(n800_key_event, s); qemu_add_kbd_event_handler(n800_key_event, s);
@ -308,8 +312,9 @@ static void n810_key_event(void *opaque, int keycode)
int code = s->keymap[keycode & 0x7f]; int code = s->keymap[keycode & 0x7f];
if (code == -1) { if (code == -1) {
if ((keycode & 0x7f) == RETU_KEYCODE) if ((keycode & 0x7f) == RETU_KEYCODE) {
retu_key_event(s->retu, !(keycode & 0x80)); retu_key_event(s->retu, !(keycode & 0x80));
}
return; return;
} }
@ -388,11 +393,14 @@ static void n810_kbd_setup(struct n800_s *s)
qemu_irq kbd_irq = qdev_get_gpio_in(s->mpu->gpio, N810_KEYBOARD_GPIO); qemu_irq kbd_irq = qdev_get_gpio_in(s->mpu->gpio, N810_KEYBOARD_GPIO);
int i; int i;
for (i = 0; i < 0x80; i ++) for (i = 0; i < 0x80; i++) {
s->keymap[i] = -1; s->keymap[i] = -1;
for (i = 0; i < 0x80; i ++) }
if (n810_keys[i] > 0) for (i = 0; i < 0x80; i++) {
if (n810_keys[i] > 0) {
s->keymap[n810_keys[i]] = i; s->keymap[n810_keys[i]] = i;
}
}
qemu_add_kbd_event_handler(n810_key_event, s); qemu_add_kbd_event_handler(n810_key_event, s);
@ -449,17 +457,20 @@ static uint32_t mipid_txrx(void *opaque, uint32_t cmd, int len)
struct mipid_s *s = (struct mipid_s *) opaque; struct mipid_s *s = (struct mipid_s *) opaque;
uint8_t ret; uint8_t ret;
if (len > 9) if (len > 9) {
hw_error("%s: FIXME: bad SPI word width %i\n", __FUNCTION__, len); hw_error("%s: FIXME: bad SPI word width %i\n", __FUNCTION__, len);
}
if (s->p >= ARRAY_SIZE(s->resp)) if (s->p >= ARRAY_SIZE(s->resp)) {
ret = 0; ret = 0;
else } else {
ret = s->resp[s->p++]; ret = s->resp[s->p++];
if (s->pm --> 0) }
if (s->pm-- > 0) {
s->param[s->pm] = cmd; s->param[s->pm] = cmd;
else } else {
s->cmd = cmd; s->cmd = cmd;
}
switch (s->cmd) { switch (s->cmd) {
case 0x00: /* NOP */ case 0x00: /* NOP */
@ -560,15 +571,17 @@ static uint32_t mipid_txrx(void *opaque, uint32_t cmd, int len)
goto bad_cmd; goto bad_cmd;
case 0x25: /* WRCNTR */ case 0x25: /* WRCNTR */
if (s->pm < 0) if (s->pm < 0) {
s->pm = 1; s->pm = 1;
}
goto bad_cmd; goto bad_cmd;
case 0x26: /* GAMSET */ case 0x26: /* GAMSET */
if (!s->pm) if (!s->pm) {
s->gamma = ffs(s->param[0] & 0xf) - 1; s->gamma = ffs(s->param[0] & 0xf) - 1;
else if (s->pm < 0) } else if (s->pm < 0) {
s->pm = 1; s->pm = 1;
}
break; break;
case 0x28: /* DISPOFF */ case 0x28: /* DISPOFF */
@ -591,10 +604,11 @@ static uint32_t mipid_txrx(void *opaque, uint32_t cmd, int len)
s->te = 0; s->te = 0;
break; break;
case 0x35: /* TEON */ case 0x35: /* TEON */
if (!s->pm) if (!s->pm) {
s->te = 1; s->te = 1;
else if (s->pm < 0) } else if (s->pm < 0) {
s->pm = 1; s->pm = 1;
}
break; break;
case 0x36: /* MADCTR */ case 0x36: /* MADCTR */
@ -613,8 +627,9 @@ static uint32_t mipid_txrx(void *opaque, uint32_t cmd, int len)
case 0xb0: /* CLKINT / DISCTL */ case 0xb0: /* CLKINT / DISCTL */
case 0xb1: /* CLKEXT */ case 0xb1: /* CLKEXT */
if (s->pm < 0) if (s->pm < 0) {
s->pm = 2; s->pm = 2;
}
break; break;
case 0xb4: /* FRMSEL */ case 0xb4: /* FRMSEL */
@ -635,8 +650,9 @@ static uint32_t mipid_txrx(void *opaque, uint32_t cmd, int len)
break; break;
case 0xc2: /* IFMOD */ case 0xc2: /* IFMOD */
if (s->pm < 0) if (s->pm < 0) {
s->pm = 2; s->pm = 2;
}
break; break;
case 0xc6: /* PWRCTL */ case 0xc6: /* PWRCTL */
@ -852,8 +868,9 @@ static void n800_setup_nolo_tags(void *sram_base)
/* OMAP STI console? Pin out settings? */ /* OMAP STI console? Pin out settings? */
ADD_TAG(0x6e01, 414); ADD_TAG(0x6e01, 414);
for (i = 0; i < ARRAY_SIZE(n800_pinout); i ++) for (i = 0; i < ARRAY_SIZE(n800_pinout); i++) {
stl_raw(v++, n800_pinout[i]); stl_raw(v++, n800_pinout[i]);
}
/* Kernel memsize? */ /* Kernel memsize? */
ADD_TAG(0x6e05, 1); ADD_TAG(0x6e05, 1);
@ -1032,9 +1049,10 @@ static void n8x0_boot_init(void *opaque)
s->mpu->cpu->env.GE = 0x5; s->mpu->cpu->env.GE = 0x5;
/* If the machine has a slided keyboard, open it */ /* If the machine has a slided keyboard, open it */
if (s->kbd) if (s->kbd) {
qemu_irq_raise(qdev_get_gpio_in(s->mpu->gpio, N810_SLIDE_GPIO)); qemu_irq_raise(qdev_get_gpio_in(s->mpu->gpio, N810_SLIDE_GPIO));
} }
}
#define OMAP_TAG_NOKIA_BT 0x4e01 #define OMAP_TAG_NOKIA_BT 0x4e01
#define OMAP_TAG_WLAN_CX3110X 0x4e02 #define OMAP_TAG_WLAN_CX3110X 0x4e02
@ -1315,9 +1333,9 @@ static void n8x0_init(MachineState *machine,
n8x0_gpio_setup(s); n8x0_gpio_setup(s);
n8x0_nand_setup(s); n8x0_nand_setup(s);
n8x0_i2c_setup(s); n8x0_i2c_setup(s);
if (model == 800) if (model == 800) {
n800_tsc_kbd_setup(s); n800_tsc_kbd_setup(s);
else if (model == 810) { } else if (model == 810) {
n810_tsc_setup(s); n810_tsc_setup(s);
n810_kbd_setup(s); n810_kbd_setup(s);
} }