ShuriZma
/
xqemu
mirror of https://github.com/xqemu/xqemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Deprecate HMP `cpu-add` 

Since we're deprecating the QMP `cpu-add`, let's deprecate its HMP
equivalent, too.

Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
Message-Id: <20181030123526.26415-3-kchamart@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
Kashyap Chamarthy 2018-10-30 13:35:25 +01:00 committed by Eduardo Habkost
parent 3800db787f
commit e25701b730
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hmp-commands.hx
View File

@ -1849,14 +1849,16 @@ ETEXI
.name = "cpu-add", .name = "cpu-add",
.args_type = "id:i", .args_type = "id:i",
.params = "id", .params = "id",
.help = "add cpu", .help = "add cpu (deprecated, use device_add instead)",
.cmd = hmp_cpu_add, .cmd = hmp_cpu_add,
}, },
STEXI STEXI
@item cpu-add @var{id} @item cpu-add @var{id}
@findex cpu-add @findex cpu-add
Add CPU with id @var{id} Add CPU with id @var{id}. This command is deprecated, please
+use @code{device_add} instead. For details, refer to
'docs/cpu-hotplug.rst'.
ETEXI ETEXI
{ {

2
hmp.c
View File

@ -2372,6 +2372,8 @@ void hmp_cpu_add(Monitor *mon, const QDict *qdict)
int cpuid; int cpuid;
Error *err = NULL; Error *err = NULL;
error_report("cpu_add is deprecated, please use device_add instead");
cpuid = qdict_get_int(qdict, "id"); cpuid = qdict_get_int(qdict, "id");
qmp_cpu_add(cpuid, &err); qmp_cpu_add(cpuid, &err);
hmp_handle_error(mon, &err); hmp_handle_error(mon, &err);