ShuriZma
/
xqemu
mirror of https://github.com/xqemu/xqemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vnc: tight: remove a memleak in send_jpeg_rect() 

buf was never freed.

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Corentin Chary 2010-07-07 20:57:55 +02:00 committed by Anthony Liguori
parent 5d8efe39a2
commit d9c18c24b9
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ui/vnc-enc-tight.c
View File

@ -1247,8 +1247,6 @@ static int send_jpeg_rect(VncState *vs, int x, int y, int w, int h, int quality)
if (ds_get_bytes_per_pixel(vs->ds) == 1) if (ds_get_bytes_per_pixel(vs->ds) == 1)
return send_full_color_rect(vs, w, h); return send_full_color_rect(vs, w, h);
buf = qemu_malloc(w * 3);
row[0] = buf;
buffer_reserve(&vs->tight_jpeg, 2048); buffer_reserve(&vs->tight_jpeg, 2048);
cinfo.err = jpeg_std_error(&jerr); cinfo.err = jpeg_std_error(&jerr);
@ -1270,10 +1268,13 @@ static int send_jpeg_rect(VncState *vs, int x, int y, int w, int h, int quality)
jpeg_start_compress(&cinfo, true); jpeg_start_compress(&cinfo, true);
buf = qemu_malloc(w * 3);
row[0] = buf;
for (dy = 0; dy < h; dy++) { for (dy = 0; dy < h; dy++) {
jpeg_prepare_row(vs, buf, x, y + dy, w); jpeg_prepare_row(vs, buf, x, y + dy, w);
jpeg_write_scanlines(&cinfo, row, 1); jpeg_write_scanlines(&cinfo, row, 1);
} }
qemu_free(buf);
jpeg_finish_compress(&cinfo); jpeg_finish_compress(&cinfo);
jpeg_destroy_compress(&cinfo); jpeg_destroy_compress(&cinfo);