mirror of https://github.com/xqemu/xqemu.git
arm: virt: Fix segmentation fault when specifying an unsupported CPU
Using -cpu cortex-a9 (or any other unsupported CPU) with the virt
board will cause QEMU to segmentation fault. This bug was introduced
in commit 9ac4ef77
, which incorrectly added a NULL terminator when
converting the VirtBoardInfo array into a simple array of strings
defining the valid CPUs. The cpuname_valid() loop already has
a termination condition based on ARRAY_SIZE, so the NULL is
spurious and causes the strcmp() to segfault if we reach it.
Delete the NULL.
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
Message-id: 1484619334-10488-1-git-send-email-zhaoshenglong@huawei.com
[PMM: expanded commit message]
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
parent
d769a1da34
commit
abf3a4e5ee
|
@ -167,7 +167,6 @@ static const char *valid_cpus[] = {
|
|||
"cortex-a53",
|
||||
"cortex-a57",
|
||||
"host",
|
||||
NULL
|
||||
};
|
||||
|
||||
static bool cpuname_valid(const char *cpu)
|
||||
|
|
Loading…
Reference in New Issue