mirror of https://github.com/xqemu/xqemu.git
spapr_pci: use the common _FDT() helper
All other users in hw/ppc already consider an error when building the FDT to be fatal, even on hotplug paths. There's no valid reason for spapr_pci to behave differently. So let's used the common _FDT() helper which terminates QEMU when libfdt fails. Signed-off-by: Greg Kurz <groug@kaod.org> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
parent
30bf9ed168
commit
99372e785e
|
@ -40,7 +40,7 @@
|
||||||
#include "trace.h"
|
#include "trace.h"
|
||||||
#include "qemu/error-report.h"
|
#include "qemu/error-report.h"
|
||||||
#include "qapi/qmp/qerror.h"
|
#include "qapi/qmp/qerror.h"
|
||||||
|
#include "hw/ppc/fdt.h"
|
||||||
#include "hw/pci/pci_bridge.h"
|
#include "hw/pci/pci_bridge.h"
|
||||||
#include "hw/pci/pci_bus.h"
|
#include "hw/pci/pci_bus.h"
|
||||||
#include "hw/pci/pci_ids.h"
|
#include "hw/pci/pci_ids.h"
|
||||||
|
@ -61,14 +61,6 @@
|
||||||
#define RTAS_TYPE_MSI 1
|
#define RTAS_TYPE_MSI 1
|
||||||
#define RTAS_TYPE_MSIX 2
|
#define RTAS_TYPE_MSIX 2
|
||||||
|
|
||||||
#define _FDT(exp) \
|
|
||||||
do { \
|
|
||||||
int ret = (exp); \
|
|
||||||
if (ret < 0) { \
|
|
||||||
return ret; \
|
|
||||||
} \
|
|
||||||
} while (0)
|
|
||||||
|
|
||||||
sPAPRPHBState *spapr_pci_find_phb(sPAPRMachineState *spapr, uint64_t buid)
|
sPAPRPHBState *spapr_pci_find_phb(sPAPRMachineState *spapr, uint64_t buid)
|
||||||
{
|
{
|
||||||
sPAPRPHBState *sphb;
|
sPAPRPHBState *sphb;
|
||||||
|
|
Loading…
Reference in New Issue