ShuriZma
/
xqemu
mirror of https://github.com/xqemu/xqemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

block/qapi: Plug memory leak on query-block error path 

Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Markus Armbruster 2015-11-20 13:53:35 +01:00 committed by Kevin Wolf
parent 98caa5bc00
commit 903c341d57
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
block/qapi.c
View File

@ -436,7 +436,9 @@ BlockInfoList *qmp_query_block(Error **errp)
bdrv_query_info(blk, &info->value, &local_err); bdrv_query_info(blk, &info->value, &local_err);
if (local_err) { if (local_err) {
error_propagate(errp, local_err); error_propagate(errp, local_err);
goto err; g_free(info);
qapi_free_BlockInfoList(head);
return NULL;
} }
*p_next = info; *p_next = info;
@ -444,10 +446,6 @@ BlockInfoList *qmp_query_block(Error **errp)
} }
return head; return head;
err:
qapi_free_BlockInfoList(head);
return NULL;
} }
BlockStatsList *qmp_query_blockstats(bool has_query_nodes, BlockStatsList *qmp_query_blockstats(bool has_query_nodes,