ShuriZma
/
xqemu
mirror of https://github.com/xqemu/xqemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hmp: Disable chardev-add and chardev-remove 

As a general rule, HMP commands must be built on top of the QMP API.
Luiz and others have worked long & hard to make HMP conform to this
rule.

Commit f1088908 added chardev-add, in violation of this rule.  QMP
command chardev-add was added right before, with minimal features, and
the idea to complete it step by step, then switch over the HMP command
to use it.

Unfortunately, we're not there, yet, and we don't want to release with
chardev-add in a "HMP is more powerful than QMP" state.

Disable the HMP command for now, along with its chardev-remove buddy.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Markus Armbruster 2013-02-06 17:07:46 +01:00 committed by Anthony Liguori
parent 543f34126b
commit 8a14952c9d
1 changed files with 32 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
hmp-commands.hx
View File

@ -1522,37 +1522,38 @@ passed since 1970, i.e. unix epoch.
@end table @end table
ETEXI ETEXI
{ HXCOMM Disabled for now, because it isn't built on top of QMP's chardev-add
.name = "chardev-add", HXCOMM {
.args_type = "args:s", HXCOMM .name = "chardev-add",
.params = "args", HXCOMM .args_type = "args:s",
.help = "add chardev", HXCOMM .params = "args",
.mhandler.cmd = hmp_chardev_add, HXCOMM .help = "add chardev",
}, HXCOMM .mhandler.cmd = hmp_chardev_add,
HXCOMM },
STEXI HXCOMM
@item chardev_add args HXCOMM STEXI
@findex chardev_add HXCOMM @item chardev_add args
HXCOMM @findex chardev_add
chardev_add accepts the same parameters as the -chardev command line switch. HXCOMM
HXCOMM chardev_add accepts the same parameters as the -chardev command line switch.
ETEXI HXCOMM
HXCOMM ETEXI
{ HXCOMM
.name = "chardev-remove", HXCOMM {
.args_type = "id:s", HXCOMM .name = "chardev-remove",
.params = "id", HXCOMM .args_type = "id:s",
.help = "remove chardev", HXCOMM .params = "id",
.mhandler.cmd = hmp_chardev_remove, HXCOMM .help = "remove chardev",
}, HXCOMM .mhandler.cmd = hmp_chardev_remove,
HXCOMM },
STEXI HXCOMM
@item chardev_remove id HXCOMM STEXI
@findex chardev_remove HXCOMM @item chardev_remove id
HXCOMM @findex chardev_remove
Removes the chardev @var{id}. HXCOMM
HXCOMM Removes the chardev @var{id}.
ETEXI HXCOMM
HXCOMM ETEXI
{ {
.name = "info", .name = "info",