ShuriZma
/
xqemu
mirror of https://github.com/xqemu/xqemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't abort on memory allocation error 

It is better to fail migration in case of failure to
allocate new cache item

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
This commit is contained in:
Orit Wasserman 2014-01-30 20:08:38 +02:00 committed by Juan Quintela
parent a17b2fd358
commit 89db9987c0
3 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arch_init.c
View File

@ -284,7 +284,9 @@ static int save_xbzrle_page(QEMUFile *f, uint8_t *current_data,
if (!cache_is_cached(XBZRLE.cache, current_addr)) { if (!cache_is_cached(XBZRLE.cache, current_addr)) {
if (!last_stage) { if (!last_stage) {
cache_insert(XBZRLE.cache, current_addr, current_data); if (cache_insert(XBZRLE.cache, current_addr, current_data) == -1) {
return -1;
}
} }
acct_info.xbzrle_cache_miss++; acct_info.xbzrle_cache_miss++;
return -1; return -1;

4
include/migration/page_cache.h
View File

@ -60,11 +60,13 @@ uint8_t *get_cached_data(const PageCache *cache, uint64_t addr);
* cache_insert: insert the page into the cache. the page cache * cache_insert: insert the page into the cache. the page cache
* will dup the data on insert. the previous value will be overwritten * will dup the data on insert. the previous value will be overwritten
* *
* Returns -1 on error
*
* @cache pointer to the PageCache struct * @cache pointer to the PageCache struct
* @addr: page address * @addr: page address
* @pdata: pointer to the page * @pdata: pointer to the page
*/ */
void cache_insert(PageCache *cache, uint64_t addr, uint8_t *pdata); int cache_insert(PageCache *cache, uint64_t addr, uint8_t *pdata);
/** /**
* cache_resize: resize the page cache. In case of size reduction the extra * cache_resize: resize the page cache. In case of size reduction the extra

16
page_cache.c
View File

@ -150,7 +150,7 @@ uint8_t *get_cached_data(const PageCache *cache, uint64_t addr)
return cache_get_by_addr(cache, addr)->it_data; return cache_get_by_addr(cache, addr)->it_data;
} }
void cache_insert(PageCache *cache, uint64_t addr, uint8_t *pdata) int cache_insert(PageCache *cache, uint64_t addr, uint8_t *pdata)
{ {
CacheItem *it = NULL; CacheItem *it = NULL;
@ -161,16 +161,22 @@ void cache_insert(PageCache *cache, uint64_t addr, uint8_t *pdata)
/* actual update of entry */ /* actual update of entry */
it = cache_get_by_addr(cache, addr); it = cache_get_by_addr(cache, addr);
/* free old cached data if any */ /* allocate page */
g_free(it->it_data);
if (!it->it_data) { if (!it->it_data) {
it->it_data = g_try_malloc(cache->page_size);
if (!it->it_data) {
DPRINTF("Error allocating page\n");
return -1;
}
cache->num_items++; cache->num_items++;
} }
it->it_data = g_memdup(pdata, cache->page_size); memcpy(it->it_data, pdata, cache->page_size);
it->it_age = ++cache->max_item_age; it->it_age = ++cache->max_item_age;
it->it_addr = addr; it->it_addr = addr;
return 0;
} }
int64_t cache_resize(PageCache *cache, int64_t new_num_pages) int64_t cache_resize(PageCache *cache, int64_t new_num_pages)