ShuriZma
/
xqemu
mirror of https://github.com/xqemu/xqemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hd-geometry: Clean up gratuitous goto in hd_geometry_guess() 

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Markus Armbruster 2012-07-10 11:12:35 +02:00 committed by Kevin Wolf
parent 2fa5008ffd
commit 82b11662be
1 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
hw/hd-geometry.c
View File

@ -119,8 +119,7 @@ static void guess_chs_for_size(BlockDriverState *bs,
void hd_geometry_guess(BlockDriverState *bs, void hd_geometry_guess(BlockDriverState *bs,
int *pcyls, int *pheads, int *psecs) int *pcyls, int *pheads, int *psecs)
{ {
int translation, lba_detected = 0; int cylinders, heads, secs, translation;
int cylinders, heads, secs;
bdrv_get_geometry_hint(bs, &cylinders, &heads, &secs); bdrv_get_geometry_hint(bs, &cylinders, &heads, &secs);
translation = bdrv_get_translation_hint(bs); translation = bdrv_get_translation_hint(bs);
@ -135,23 +134,18 @@ void hd_geometry_guess(BlockDriverState *bs,
if (guess_disk_lchs(bs, &cylinders, &heads, &secs) < 0) { if (guess_disk_lchs(bs, &cylinders, &heads, &secs) < 0) {
/* no LCHS guess: use a standard physical disk geometry */ /* no LCHS guess: use a standard physical disk geometry */
default_geometry:
guess_chs_for_size(bs, pcyls, pheads, psecs); guess_chs_for_size(bs, pcyls, pheads, psecs);
if ((lba_detected == 1) && (translation == BIOS_ATA_TRANSLATION_AUTO)) {
if ((*pcyls * *pheads) <= 131072) {
bdrv_set_translation_hint(bs,
BIOS_ATA_TRANSLATION_LARGE);
} else {
bdrv_set_translation_hint(bs,
BIOS_ATA_TRANSLATION_LBA);
}
}
} else if (heads > 16) { } else if (heads > 16) {
/* LCHS guess with heads > 16 means that a BIOS LBA /* LCHS guess with heads > 16 means that a BIOS LBA
translation was active, so a standard physical disk translation was active, so a standard physical disk
geometry is OK */ geometry is OK */
lba_detected = 1; guess_chs_for_size(bs, pcyls, pheads, psecs);
goto default_geometry; if (translation == BIOS_ATA_TRANSLATION_AUTO) {
bdrv_set_translation_hint(bs,
*pcyls * *pheads <= 131072
? BIOS_ATA_TRANSLATION_LARGE
: BIOS_ATA_TRANSLATION_LBA);
}
} else { } else {
/* LCHS guess with heads <= 16: use as physical geometry */ /* LCHS guess with heads <= 16: use as physical geometry */
*pcyls = cylinders; *pcyls = cylinders;