ShuriZma
/
xqemu
mirror of https://github.com/xqemu/xqemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

blockjob: strengthen a bit test-blockjob-txn 

Unlike test-blockjob-txn, QMP releases the reference to the transaction
before the jobs finish.  Thus, qemu-iotest 124 showed a failure while
working on the next patch that the unit tests did not have.  Make
the test a little nastier.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20170508141310.8674-10-pbonzini@redhat.com
Signed-off-by: Jeff Cody <jcody@redhat.com>
This commit is contained in:
Paolo Bonzini 2017-05-08 16:13:08 +02:00 committed by Jeff Cody
parent c8ab5c2dde
commit 7e74a73499
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/test-blockjob-txn.c
View File

@ -167,6 +167,11 @@ static void test_pair_jobs(int expected1, int expected2)
block_job_start(job1); block_job_start(job1);
block_job_start(job2); block_job_start(job2);
/* Release our reference now to trigger as many nice
* use-after-free bugs as possible.
*/
block_job_txn_unref(txn);
if (expected1 == -ECANCELED) { if (expected1 == -ECANCELED) {
block_job_cancel(job1); block_job_cancel(job1);
} }
@ -187,8 +192,6 @@ static void test_pair_jobs(int expected1, int expected2)
g_assert_cmpint(result1, ==, expected1); g_assert_cmpint(result1, ==, expected1);
g_assert_cmpint(result2, ==, expected2); g_assert_cmpint(result2, ==, expected2);
block_job_txn_unref(txn);
} }
static void test_pair_jobs_success(void) static void test_pair_jobs_success(void)