mirror of https://github.com/xqemu/xqemu.git
s390x/sclp: mark sclp-cpu-hotplug as non-usercreatable
A TYPE_SCLP_CPU_HOTPLUG device for handling cpu hotplug events is already created by the sclp event facility. Adding a second TYPE_SCLP_CPU_HOTPLUG device via -device sclp-cpu-hotplug creates an ambiguity in raise_irq_cpu_hotplug(), leading to a crash once a cpu is hotplugged. To fix this, disallow creating a sclp-cpu-hotplug device manually. Reviewed-by: Thomas Huth <thuth@redhat.com> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
This commit is contained in:
parent
e6cb60bf15
commit
7aa4d85d29
|
@ -82,6 +82,12 @@ static void cpu_class_init(ObjectClass *oc, void *data)
|
||||||
k->get_receive_mask = receive_mask;
|
k->get_receive_mask = receive_mask;
|
||||||
k->read_event_data = read_event_data;
|
k->read_event_data = read_event_data;
|
||||||
set_bit(DEVICE_CATEGORY_MISC, dc->categories);
|
set_bit(DEVICE_CATEGORY_MISC, dc->categories);
|
||||||
|
/*
|
||||||
|
* Reason: raise_irq_cpu_hotplug() depends on an unique
|
||||||
|
* TYPE_SCLP_CPU_HOTPLUG device, which is already created
|
||||||
|
* by the sclp event facility
|
||||||
|
*/
|
||||||
|
dc->user_creatable = false;
|
||||||
}
|
}
|
||||||
|
|
||||||
static const TypeInfo sclp_cpu_info = {
|
static const TypeInfo sclp_cpu_info = {
|
||||||
|
|
Loading…
Reference in New Issue