mirror of https://github.com/xqemu/xqemu.git
pci: insert assert that auto-assigned-address function is single function device.
Auto-assigned-address pci function (passing devfn = -1) is always single function. This patch adds assert() to guarantee that auto-assigned-address function is always single function device at function = 0. Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
This commit is contained in:
parent
520128bde8
commit
6fa84913ec
3
hw/pci.c
3
hw/pci.c
|
@ -227,6 +227,7 @@ void pci_bus_new_inplace(PCIBus *bus, DeviceState *parent,
|
||||||
const char *name, int devfn_min)
|
const char *name, int devfn_min)
|
||||||
{
|
{
|
||||||
qbus_create_inplace(&bus->qbus, &pci_bus_info, parent, name);
|
qbus_create_inplace(&bus->qbus, &pci_bus_info, parent, name);
|
||||||
|
assert(PCI_FUNC(devfn_min) == 0);
|
||||||
bus->devfn_min = devfn_min;
|
bus->devfn_min = devfn_min;
|
||||||
|
|
||||||
/* host bridge */
|
/* host bridge */
|
||||||
|
@ -608,7 +609,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
|
||||||
{
|
{
|
||||||
if (devfn < 0) {
|
if (devfn < 0) {
|
||||||
for(devfn = bus->devfn_min ; devfn < ARRAY_SIZE(bus->devices);
|
for(devfn = bus->devfn_min ; devfn < ARRAY_SIZE(bus->devices);
|
||||||
devfn += 8) {
|
devfn += PCI_FUNC_MAX) {
|
||||||
if (!bus->devices[devfn])
|
if (!bus->devices[devfn])
|
||||||
goto found;
|
goto found;
|
||||||
}
|
}
|
||||||
|
|
1
hw/pci.h
1
hw/pci.h
|
@ -14,6 +14,7 @@
|
||||||
#define PCI_DEVFN(slot, func) ((((slot) & 0x1f) << 3) | ((func) & 0x07))
|
#define PCI_DEVFN(slot, func) ((((slot) & 0x1f) << 3) | ((func) & 0x07))
|
||||||
#define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f)
|
#define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f)
|
||||||
#define PCI_FUNC(devfn) ((devfn) & 0x07)
|
#define PCI_FUNC(devfn) ((devfn) & 0x07)
|
||||||
|
#define PCI_FUNC_MAX 8
|
||||||
|
|
||||||
/* Class, Vendor and Device IDs from Linux's pci_ids.h */
|
/* Class, Vendor and Device IDs from Linux's pci_ids.h */
|
||||||
#include "pci_ids.h"
|
#include "pci_ids.h"
|
||||||
|
|
Loading…
Reference in New Issue