ShuriZma
/
xqemu
mirror of https://github.com/xqemu/xqemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bochs: Fix bdrv_open() error handling 

Return -errno instead of -1 on errors. While touching the
code, fix a memory leak.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
Kevin Wolf 2013-01-25 17:07:27 +01:00 committed by Stefan Hajnoczi
parent 6f74c260b4
commit 5b7d7dfd19
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
block/bochs.c
View File

@ -114,11 +114,13 @@ static int bochs_open(BlockDriverState *bs, int flags)
int i; int i;
struct bochs_header bochs; struct bochs_header bochs;
struct bochs_header_v1 header_v1; struct bochs_header_v1 header_v1;
int ret;
bs->read_only = 1; // no write support yet bs->read_only = 1; // no write support yet
if (bdrv_pread(bs->file, 0, &bochs, sizeof(bochs)) != sizeof(bochs)) { ret = bdrv_pread(bs->file, 0, &bochs, sizeof(bochs));
goto fail; if (ret < 0) {
return ret;
} }
if (strcmp(bochs.magic, HEADER_MAGIC) || if (strcmp(bochs.magic, HEADER_MAGIC) ||
@ -138,9 +140,13 @@ static int bochs_open(BlockDriverState *bs, int flags)
s->catalog_size = le32_to_cpu(bochs.extra.redolog.catalog); s->catalog_size = le32_to_cpu(bochs.extra.redolog.catalog);
s->catalog_bitmap = g_malloc(s->catalog_size * 4); s->catalog_bitmap = g_malloc(s->catalog_size * 4);
if (bdrv_pread(bs->file, le32_to_cpu(bochs.header), s->catalog_bitmap,
s->catalog_size * 4) != s->catalog_size * 4) ret = bdrv_pread(bs->file, le32_to_cpu(bochs.header), s->catalog_bitmap,
goto fail; s->catalog_size * 4);
if (ret < 0) {
goto fail;
}
for (i = 0; i < s->catalog_size; i++) for (i = 0; i < s->catalog_size; i++)
le32_to_cpus(&s->catalog_bitmap[i]); le32_to_cpus(&s->catalog_bitmap[i]);
@ -153,8 +159,10 @@ static int bochs_open(BlockDriverState *bs, int flags)
qemu_co_mutex_init(&s->lock); qemu_co_mutex_init(&s->lock);
return 0; return 0;
fail:
return -1; fail:
g_free(s->catalog_bitmap);
return ret;
} }
static int64_t seek_to_sector(BlockDriverState *bs, int64_t sector_num) static int64_t seek_to_sector(BlockDriverState *bs, int64_t sector_num)