mirror of https://github.com/xqemu/xqemu.git
exec: assert that RAMBlock size is non-zero
find_ram_offset() does not handle size=0 gracefully. It hands out the same RAMBlock offset multiple times, leading to obscure failures later on. Add an assert to warn early if something is incorrectly allocating a zero size RAMBlock. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
parent
8c7f3dd05e
commit
49cd9ac6a1
2
exec.c
2
exec.c
|
@ -925,6 +925,8 @@ static ram_addr_t find_ram_offset(ram_addr_t size)
|
||||||
RAMBlock *block, *next_block;
|
RAMBlock *block, *next_block;
|
||||||
ram_addr_t offset = RAM_ADDR_MAX, mingap = RAM_ADDR_MAX;
|
ram_addr_t offset = RAM_ADDR_MAX, mingap = RAM_ADDR_MAX;
|
||||||
|
|
||||||
|
assert(size != 0); /* it would hand out same offset multiple times */
|
||||||
|
|
||||||
if (QTAILQ_EMPTY(&ram_list.blocks))
|
if (QTAILQ_EMPTY(&ram_list.blocks))
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue