ShuriZma
/
xqemu
mirror of https://github.com/xqemu/xqemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: ne2000: check ring buffer control registers 

Ne2000 NIC uses ring buffer of NE2000_MEM_SIZE(49152)
bytes to process network packets. Registers PSTART & PSTOP
define ring buffer size & location. Setting these registers
to invalid values could lead to infinite loop or OOB r/w
access issues. Add check to avoid it.

Reported-by: Yang Hongke <yanghongke@huawei.com>
Tested-by: Yang Hongke <yanghongke@huawei.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
This commit is contained in:
Prasad J Pandit 2016-02-24 11:41:33 +05:30 committed by Jason Wang
parent 97556fe80e
commit 415ab35a44
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/net/ne2000.c
View File

@ -155,6 +155,10 @@ static int ne2000_buffer_full(NE2000State *s)
{ {
int avail, index, boundary; int avail, index, boundary;
if (s->stop <= s->start) {
return 1;
}
index = s->curpag << 8; index = s->curpag << 8;
boundary = s->boundary << 8; boundary = s->boundary << 8;
if (index < boundary) if (index < boundary)