ShuriZma
/
xqemu
mirror of https://github.com/xqemu/xqemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

QemuOpts: Simplify qemu_opts_to_qdict() 

Noticed while investigating Coccinelle cleanups. There is no need
for a temporary variable when we can use the new macro to do the
same thing with less typing.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20170427215821.19397-9-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
Eric Blake 2017-04-27 16:58:19 -05:00 committed by Markus Armbruster
parent ff6ed7141d
commit 28934e0c75
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/qemu-option.c
View File

@ -1054,7 +1054,6 @@ void qemu_opts_absorb_qdict(QemuOpts *opts, QDict *qdict, Error **errp)
QDict *qemu_opts_to_qdict(QemuOpts *opts, QDict *qdict) QDict *qemu_opts_to_qdict(QemuOpts *opts, QDict *qdict)
{ {
QemuOpt *opt; QemuOpt *opt;
QObject *val;
if (!qdict) { if (!qdict) {
qdict = qdict_new(); qdict = qdict_new();
@ -1063,8 +1062,7 @@ QDict *qemu_opts_to_qdict(QemuOpts *opts, QDict *qdict)
qdict_put_str(qdict, "id", opts->id); qdict_put_str(qdict, "id", opts->id);
} }
QTAILQ_FOREACH(opt, &opts->head, next) { QTAILQ_FOREACH(opt, &opts->head, next) {
val = QOBJECT(qstring_from_str(opt->str)); qdict_put_str(qdict, opt->name, opt->str);
qdict_put_obj(qdict, opt->name, val);
} }
return qdict; return qdict;
} }