ShuriZma
/
xqemu
mirror of https://github.com/xqemu/xqemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

monitor: fix qmp_getfd() fd leak in error case 

qemu_chr_fe_get_msgfd() transfers ownership of the file descriptor to
the caller.  Therefore all code paths in qmp_getfd() should either
register the file descriptor somewhere or close it.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
This commit is contained in:
Stefan Hajnoczi 2014-04-24 13:58:18 +02:00 committed by Luiz Capitulino
parent 1b7a0f758b
commit 0b9f0e2fd7
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
monitor.c
View File

@ -2228,6 +2228,7 @@ void qmp_getfd(const char *fdname, Error **errp)
} }
if (qemu_isdigit(fdname[0])) { if (qemu_isdigit(fdname[0])) {
close(fd);
error_set(errp, QERR_INVALID_PARAMETER_VALUE, "fdname", error_set(errp, QERR_INVALID_PARAMETER_VALUE, "fdname",
"a name not starting with a digit"); "a name not starting with a digit");
return; return;