mirror of https://github.com/xqemu/xqemu.git
qom: Make object_property_set_qobject()'s input visitor strict
Commit 240f64b
made all qobject input visitors created outside tests
strict, except for the one in object_property_set_qobject(). That one
was left behind only because Eric couldn't spare the time to figure
out whether making it strict would break anything, with a TODO
comment. Time to resolve it.
Strict makes a difference only for otherwise successful visits of QAPI
structs or unions. Let's examine what the callers of
object_property_set_qobject() visit:
* object_property_set_str(), object_property_set_bool(),
object_property_set_int() visit a QString, QBool, QInt,
respectively. Strictness can't matter.
* qmp_qom_set visits its @value argument. Comes straight from QMP and
can be anything ('any' in the QAPI schema). Strictness matters when
the property's set() method visits a struct or union QAPI type.
No such methods exist, thus switching to strict can't break
anything.
If we acquire such methods in the future, we'll *want* the visitor
to be strict, so that unexpected members get rejected as they should
be.
Switch to strict.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1488544368-30622-18-git-send-email-armbru@redhat.com>
This commit is contained in:
parent
f332e830e3
commit
05601ed2de
|
@ -22,8 +22,8 @@ void object_property_set_qobject(Object *obj, QObject *value,
|
|||
const char *name, Error **errp)
|
||||
{
|
||||
Visitor *v;
|
||||
/* TODO: Should we reject, rather than ignore, excess input? */
|
||||
v = qobject_input_visitor_new(value, false);
|
||||
|
||||
v = qobject_input_visitor_new(value, true);
|
||||
object_property_set(obj, v, name, errp);
|
||||
visit_free(v);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue