[Vulkan] Update variableMultisampleRate comments (actually supported) [ci skip]
This commit is contained in:
parent
0b4f5ef286
commit
e97eb75b94
|
@ -2532,8 +2532,6 @@ bool VulkanCommandProcessor::IssueDraw(xenos::PrimitiveType prim_type,
|
|||
// After all commands that may dispatch, copy or insert barriers, submit the
|
||||
// barriers (may end the render pass), and (re)enter the render pass before
|
||||
// drawing.
|
||||
// TODO(Triang3l): Handle disabled variableMultisampleRate by restarting the
|
||||
// render pass with no attachments if the sample count becomes different.
|
||||
SubmitBarriersAndEnterRenderTargetCacheRenderPass(
|
||||
render_target_cache_->last_update_render_pass(),
|
||||
render_target_cache_->last_update_framebuffer());
|
||||
|
|
|
@ -44,9 +44,13 @@ class VulkanRenderTargetCache final : public RenderTargetCache {
|
|||
// targets are different for 2x and 4x guest MSAA, pipelines because the
|
||||
// sample mask will have 2 samples excluded for 2x-as-4x).
|
||||
// This has effect only on the attachments, but even in cases when there
|
||||
// are no attachments, it can be used to the sample count between
|
||||
// are no attachments, it can be used to pass the sample count between
|
||||
// subsystems, for instance, to specify the desired number of samples to
|
||||
// use when there are no attachments in pipelines.
|
||||
// Also, without attachments, using separate render passes for different
|
||||
// sample counts ensures that if the variableMultisampleRate feature is
|
||||
// not supported, no draws with different rasterization sample counts end
|
||||
// up in one render pass.
|
||||
xenos::MsaaSamples msaa_samples : xenos::kMsaaSamplesBits; // 2
|
||||
// << 0 is depth, << 1...4 is color.
|
||||
uint32_t depth_and_color_used : 1 + xenos::kMaxColorRenderTargets; // 7
|
||||
|
|
Loading…
Reference in New Issue