From cdb40ddb2869627f1474606950cffa1a1233ec75 Mon Sep 17 00:00:00 2001
From: Triang3l <triang3l@yandex.ru>
Date: Tue, 18 Oct 2022 13:12:20 +0300
Subject: [PATCH] [DXBC] Fix interpolator copying from v# to r# in PS

The bit count was of `(1<<i)-1` itself (thus couldn't handle interpolators with a smaller index skipped), not of `bits&((1<<i)-1)`.
---
 src/xenia/gpu/dxbc_shader_translator.cc | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/xenia/gpu/dxbc_shader_translator.cc b/src/xenia/gpu/dxbc_shader_translator.cc
index daa8cf782..5bf004a96 100644
--- a/src/xenia/gpu/dxbc_shader_translator.cc
+++ b/src/xenia/gpu/dxbc_shader_translator.cc
@@ -691,15 +691,14 @@ void DxbcShaderTranslator::StartPixelShader() {
     if (i == param_gen_interpolator) {
       continue;
     }
-    a_.OpMov(
-        uses_register_dynamic_addressing ? dxbc::Dest::X(0, i)
-                                         : dxbc::Dest::R(i),
-        (i < xenos::kMaxInterpolators &&
-         (interpolator_mask & (UINT32_C(1) << i)))
-            ? dxbc::Src::V1D(
-                  in_reg_ps_interpolators_ +
-                  xe::bit_count((interpolator_mask & (UINT32_C(1) << i)) - 1))
-            : dxbc::Src::LF(0.0f));
+    a_.OpMov(uses_register_dynamic_addressing ? dxbc::Dest::X(0, i)
+                                              : dxbc::Dest::R(i),
+             (i < xenos::kMaxInterpolators &&
+              (interpolator_mask & (UINT32_C(1) << i)))
+                 ? dxbc::Src::V1D(in_reg_ps_interpolators_ +
+                                  xe::bit_count(interpolator_mask &
+                                                ((UINT32_C(1) << i) - 1)))
+                 : dxbc::Src::LF(0.0f));
   }
 
   // Write the pixel parameters to the specified interpolator register