From c22f76e87f67bbffb1dd828f0e51dc7d5b6af31c Mon Sep 17 00:00:00 2001
From: gibbed <rick@gibbed.us>
Date: Wed, 4 Sep 2019 15:39:18 -0500
Subject: [PATCH] [Base] Const-ize store and store_and_swap templates.

[Base] Make value argument for store and store_and_swap templates
const&.
---
 src/xenia/base/memory.h | 50 ++++++++++++++++++++---------------------
 1 file changed, 25 insertions(+), 25 deletions(-)

diff --git a/src/xenia/base/memory.h b/src/xenia/base/memory.h
index 3819f9dbe..4188af763 100644
--- a/src/xenia/base/memory.h
+++ b/src/xenia/base/memory.h
@@ -295,49 +295,49 @@ inline std::wstring load_and_swap<std::wstring>(const void* mem) {
 }
 
 template <typename T>
-void store(void* mem, T value);
+void store(void* mem, const T& value);
 template <>
-inline void store<int8_t>(void* mem, int8_t value) {
+inline void store<int8_t>(void* mem, const int8_t& value) {
   *reinterpret_cast<int8_t*>(mem) = value;
 }
 template <>
-inline void store<uint8_t>(void* mem, uint8_t value) {
+inline void store<uint8_t>(void* mem, const uint8_t& value) {
   *reinterpret_cast<uint8_t*>(mem) = value;
 }
 template <>
-inline void store<int16_t>(void* mem, int16_t value) {
+inline void store<int16_t>(void* mem, const int16_t& value) {
   *reinterpret_cast<int16_t*>(mem) = value;
 }
 template <>
-inline void store<uint16_t>(void* mem, uint16_t value) {
+inline void store<uint16_t>(void* mem, const uint16_t& value) {
   *reinterpret_cast<uint16_t*>(mem) = value;
 }
 template <>
-inline void store<int32_t>(void* mem, int32_t value) {
+inline void store<int32_t>(void* mem, const int32_t& value) {
   *reinterpret_cast<int32_t*>(mem) = value;
 }
 template <>
-inline void store<uint32_t>(void* mem, uint32_t value) {
+inline void store<uint32_t>(void* mem, const uint32_t& value) {
   *reinterpret_cast<uint32_t*>(mem) = value;
 }
 template <>
-inline void store<int64_t>(void* mem, int64_t value) {
+inline void store<int64_t>(void* mem, const int64_t& value) {
   *reinterpret_cast<int64_t*>(mem) = value;
 }
 template <>
-inline void store<uint64_t>(void* mem, uint64_t value) {
+inline void store<uint64_t>(void* mem, const uint64_t& value) {
   *reinterpret_cast<uint64_t*>(mem) = value;
 }
 template <>
-inline void store<float>(void* mem, float value) {
+inline void store<float>(void* mem, const float& value) {
   *reinterpret_cast<float*>(mem) = value;
 }
 template <>
-inline void store<double>(void* mem, double value) {
+inline void store<double>(void* mem, const double& value) {
   *reinterpret_cast<double*>(mem) = value;
 }
 template <typename T>
-inline void store(const void* mem, T value) {
+inline void store(const void* mem, const T& value) {
   if (sizeof(T) == 1) {
     store<uint8_t>(mem, static_cast<uint8_t>(value));
   } else if (sizeof(T) == 2) {
@@ -352,55 +352,55 @@ inline void store(const void* mem, T value) {
 }
 
 template <typename T>
-void store_and_swap(void* mem, T value);
+void store_and_swap(void* mem, const T& value);
 template <>
-inline void store_and_swap<int8_t>(void* mem, int8_t value) {
+inline void store_and_swap<int8_t>(void* mem, const int8_t& value) {
   *reinterpret_cast<int8_t*>(mem) = value;
 }
 template <>
-inline void store_and_swap<uint8_t>(void* mem, uint8_t value) {
+inline void store_and_swap<uint8_t>(void* mem, const uint8_t& value) {
   *reinterpret_cast<uint8_t*>(mem) = value;
 }
 template <>
-inline void store_and_swap<int16_t>(void* mem, int16_t value) {
+inline void store_and_swap<int16_t>(void* mem, const int16_t& value) {
   *reinterpret_cast<int16_t*>(mem) = byte_swap(value);
 }
 template <>
-inline void store_and_swap<uint16_t>(void* mem, uint16_t value) {
+inline void store_and_swap<uint16_t>(void* mem, const uint16_t& value) {
   *reinterpret_cast<uint16_t*>(mem) = byte_swap(value);
 }
 template <>
-inline void store_and_swap<int32_t>(void* mem, int32_t value) {
+inline void store_and_swap<int32_t>(void* mem, const int32_t& value) {
   *reinterpret_cast<int32_t*>(mem) = byte_swap(value);
 }
 template <>
-inline void store_and_swap<uint32_t>(void* mem, uint32_t value) {
+inline void store_and_swap<uint32_t>(void* mem, const uint32_t& value) {
   *reinterpret_cast<uint32_t*>(mem) = byte_swap(value);
 }
 template <>
-inline void store_and_swap<int64_t>(void* mem, int64_t value) {
+inline void store_and_swap<int64_t>(void* mem, const int64_t& value) {
   *reinterpret_cast<int64_t*>(mem) = byte_swap(value);
 }
 template <>
-inline void store_and_swap<uint64_t>(void* mem, uint64_t value) {
+inline void store_and_swap<uint64_t>(void* mem, const uint64_t& value) {
   *reinterpret_cast<uint64_t*>(mem) = byte_swap(value);
 }
 template <>
-inline void store_and_swap<float>(void* mem, float value) {
+inline void store_and_swap<float>(void* mem, const float& value) {
   *reinterpret_cast<float*>(mem) = byte_swap(value);
 }
 template <>
-inline void store_and_swap<double>(void* mem, double value) {
+inline void store_and_swap<double>(void* mem, const double& value) {
   *reinterpret_cast<double*>(mem) = byte_swap(value);
 }
 template <>
-inline void store_and_swap<std::string>(void* mem, std::string value) {
+inline void store_and_swap<std::string>(void* mem, const std::string& value) {
   for (auto i = 0; i < value.size(); ++i) {
     xe::store_and_swap<uint8_t>(reinterpret_cast<uint8_t*>(mem) + i, value[i]);
   }
 }
 template <>
-inline void store_and_swap<std::wstring>(void* mem, std::wstring value) {
+inline void store_and_swap<std::wstring>(void* mem, const std::wstring& value) {
   for (auto i = 0; i < value.size(); ++i) {
     xe::store_and_swap<uint16_t>(reinterpret_cast<uint16_t*>(mem) + i,
                                  value[i]);