ShuriZma
/
xenia
mirror of https://github.com/xenia-project/xenia.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Kernel] Remove explicit SHIM calling convention 

Shim exports are called from GuestToHostThunk which dictates the calling
convention. The default system calling convention is different depending
on OS (Windows vs. everything else) and architecture. PR #1339 addresses
this for x64 Linux.
There is no reason for explicit `__cdecl`. Also, it is not available in
GCC. We could use `__attribute__((ms_abi))` or
`__attribute__((sysv_abi))` but that just adds complexity.
This commit is contained in:
Joel Linn 2021-05-21 00:23:16 +02:00 committed by Rick Gibbed
parent 07a060b002
commit c0fb300a05
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/xenia/kernel/util/shim_utils.h
View File

@ -29,7 +29,7 @@ namespace kernel {
using PPCContext = xe::cpu::ppc::PPCContext; using PPCContext = xe::cpu::ppc::PPCContext;
#define SHIM_CALL void __cdecl #define SHIM_CALL void
#define SHIM_SET_MAPPING(library_name, export_name, shim_data) \ #define SHIM_SET_MAPPING(library_name, export_name, shim_data) \
export_resolver->SetFunctionMapping( \ export_resolver->SetFunctionMapping( \
library_name, ordinals::export_name, \ library_name, ordinals::export_name, \