ShuriZma
/
xenia
mirror of https://github.com/xenia-project/xenia.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Optimizing memory accesses a bit by letting libjit use relative addressing.

This commit is contained in:
Ben Vanik 2013-05-23 11:46:26 -07:00
parent fc8eb3d40a
commit 89672e111d
2 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/xenia/cpu/libjit/libjit_emitter.cc
View File

@ -1275,7 +1275,7 @@ void LibjitEmitter::update_fpr_value(uint32_t n, jit_value_t value) {
jit_insn_store(fn_, locals_.fpr[n], value); jit_insn_store(fn_, locals_.fpr[n], value);
} }
jit_value_t LibjitEmitter::GetMemoryAddress(uint32_t cia, jit_value_t addr) { jit_value_t LibjitEmitter::TouchMemoryAddress(uint32_t cia, jit_value_t addr) {
// Input address is always in 32-bit space. // Input address is always in 32-bit space.
// TODO(benvanik): is this required? It's one extra instruction on every // TODO(benvanik): is this required? It's one extra instruction on every
// access... // access...
@ -1303,11 +1303,7 @@ jit_value_t LibjitEmitter::GetMemoryAddress(uint32_t cia, jit_value_t addr) {
// b.SetInsertPoint(valid_bb); // b.SetInsertPoint(valid_bb);
// } // }
// Rebase off of memory base pointer. return addr;
// We could store the memory base as a global value (or indirection off of
// state) if we wanted to avoid embedding runtime values into the code.
jit_value_t membase = get_uint64((uint64_t)xe_memory_addr(memory_, 0));
return jit_insn_add(fn_, addr, membase);
} }
jit_value_t LibjitEmitter::ReadMemory( jit_value_t LibjitEmitter::ReadMemory(
@ -1335,8 +1331,12 @@ jit_value_t LibjitEmitter::ReadMemory(
return NULL; return NULL;
} }
jit_value_t address = GetMemoryAddress(cia, addr); // Rebase off of memory base pointer.
jit_value_t value = jit_insn_load_relative(fn_, address, 0, data_type); // We could store the memory base as a global value (or indirection off of
// state) if we wanted to avoid embedding runtime values into the code.
jit_value_t address = TouchMemoryAddress(cia, addr);
jit_nint membase = (jit_nint)xe_memory_addr(memory_, 0);
jit_value_t value = jit_insn_load_relative(fn_, address, membase, data_type);
if (acquire) { if (acquire) {
// TODO(benvanik): acquire semantics. // TODO(benvanik): acquire semantics.
// load_value->setAlignment(size); // load_value->setAlignment(size);
@ -1380,8 +1380,6 @@ void LibjitEmitter::WriteMemory(
return; return;
} }
jit_value_t address = GetMemoryAddress(cia, addr);
// Truncate, if required. // Truncate, if required.
if (jit_value_get_type(value) != data_type) { if (jit_value_get_type(value) != data_type) {
value = jit_insn_convert(fn_, value, data_type, 0); value = jit_insn_convert(fn_, value, data_type, 0);
@ -1400,5 +1398,10 @@ void LibjitEmitter::WriteMemory(
// store_value->setAtomic(Release); // store_value->setAtomic(Release);
// } // }
jit_insn_store_relative(fn_, address, 0, value); // Rebase off of memory base pointer.
// We could store the memory base as a global value (or indirection off of
// state) if we wanted to avoid embedding runtime values into the code.
jit_value_t address = TouchMemoryAddress(cia, addr);
jit_nint membase = (jit_nint)xe_memory_addr(memory_, 0);
jit_insn_store_relative(fn_, address, membase, value);
} }

2
src/xenia/cpu/libjit/libjit_emitter.h
View File

@ -92,7 +92,7 @@ public:
jit_value_t fpr_value(uint32_t n); jit_value_t fpr_value(uint32_t n);
void update_fpr_value(uint32_t n, jit_value_t value); void update_fpr_value(uint32_t n, jit_value_t value);
jit_value_t GetMemoryAddress(uint32_t cia, jit_value_t addr); jit_value_t TouchMemoryAddress(uint32_t cia, jit_value_t addr);
jit_value_t ReadMemory( jit_value_t ReadMemory(
uint32_t cia, jit_value_t addr, uint32_t size, bool acquire = false); uint32_t cia, jit_value_t addr, uint32_t size, bool acquire = false);
void WriteMemory( void WriteMemory(