From 7c24f8e09f336155b30008a77281188a10eeb4ab Mon Sep 17 00:00:00 2001 From: NPCompete Date: Sat, 17 Nov 2018 14:50:00 -0800 Subject: [PATCH 1/2] [Kernel] Made xe::kernel::App destructor virtual since it is an abstract class. --- src/xenia/kernel/xam/app_manager.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/xenia/kernel/xam/app_manager.h b/src/xenia/kernel/xam/app_manager.h index 2420cdd6a..8a7655406 100644 --- a/src/xenia/kernel/xam/app_manager.h +++ b/src/xenia/kernel/xam/app_manager.h @@ -35,6 +35,8 @@ class App { virtual X_RESULT DispatchMessageSync(uint32_t message, uint32_t buffer_ptr, uint32_t buffer_length) = 0; + virtual ~App() = default; + protected: App(KernelState* kernel_state, uint32_t app_id); From da66c68bf64b20a8d36da3467a2030073dd7cf62 Mon Sep 17 00:00:00 2001 From: NPCompete Date: Sat, 17 Nov 2018 14:50:30 -0800 Subject: [PATCH 2/2] [CPU] Made xe::cpu::StackWalker destructor virtual since it is an abstract class. --- src/xenia/cpu/stack_walker.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/xenia/cpu/stack_walker.h b/src/xenia/cpu/stack_walker.h index d9cabaf6a..4dd4f44e9 100644 --- a/src/xenia/cpu/stack_walker.h +++ b/src/xenia/cpu/stack_walker.h @@ -92,6 +92,8 @@ class StackWalker { // populated. virtual bool ResolveStack(uint64_t* frame_host_pcs, StackFrame* frames, size_t frame_count) = 0; + + virtual ~StackWalker() = default; }; } // namespace cpu