ShuriZma
/
xenia
mirror of https://github.com/xenia-project/xenia.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Kernel] Solve ambiguity in `RegisterExport()` 

- Remove overload for exports with `void` return type
- Use `if constexpr (std::is_void<R>::value)` to differentiate
This commit is contained in:
Joel Linn 2021-05-20 22:47:27 +02:00 committed by Rick Gibbed
parent d40dfa11c5
commit 07a060b002
1 changed files with 13 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
src/xenia/kernel/util/shim_utils.h
View File

@ -12,6 +12,7 @@
#include <cstring> #include <cstring>
#include <string> #include <string>
#include <type_traits>
#include "third_party/fmt/include/fmt/format.h" #include "third_party/fmt/include/fmt/format.h"
#include "xenia/base/byte_order.h" #include "xenia/base/byte_order.h"
@ -531,13 +532,18 @@ xe::cpu::Export* RegisterExport(R (*fn)(Ps&...), const char* name,
cvars::log_high_frequency_kernel_calls)) { cvars::log_high_frequency_kernel_calls)) {
PrintKernelCall(export_entry, params); PrintKernelCall(export_entry, params);
} }
auto result = if constexpr (std::is_void<R>::value) {
KernelTrampoline(FN, std::forward<std::tuple<Ps...>>(params), KernelTrampoline(FN, std::forward<std::tuple<Ps...>>(params),
std::make_index_sequence<sizeof...(Ps)>()); std::make_index_sequence<sizeof...(Ps)>());
result.Store(ppc_context); } else {
if (export_entry->tags & auto result =
(xe::cpu::ExportTag::kLog | xe::cpu::ExportTag::kLogResult)) { KernelTrampoline(FN, std::forward<std::tuple<Ps...>>(params),
// TODO(benvanik): log result. std::make_index_sequence<sizeof...(Ps)>());
result.Store(ppc_context);
if (export_entry->tags &
(xe::cpu::ExportTag::kLog | xe::cpu::ExportTag::kLogResult)) {
// TODO(benvanik): log result.
}
} }
} }
}; };
@ -545,38 +551,6 @@ xe::cpu::Export* RegisterExport(R (*fn)(Ps&...), const char* name,
return export_entry; return export_entry;
} }
template <KernelModuleId MODULE, uint16_t ORDINAL, typename... Ps>
xe::cpu::Export* RegisterExport(void (*fn)(Ps&...), const char* name,
xe::cpu::ExportTag::type tags) {
static const auto export_entry = new cpu::Export(
ORDINAL, xe::cpu::Export::Type::kFunction, name,
tags | xe::cpu::ExportTag::kImplemented | xe::cpu::ExportTag::kLog);
static void (*FN)(Ps & ...) = fn;
struct X {
static void Trampoline(PPCContext* ppc_context) {
++export_entry->function_data.call_count;
Param::Init init = {
ppc_context,
0,
};
// Using braces initializer instead of make_tuple because braces
// enforce execution order across compilers.
// The make_tuple order is undefined per the C++ standard and
// cause inconsitencies between msvc and clang.
std::tuple<Ps...> params = {Ps(init)...};
if (export_entry->tags & xe::cpu::ExportTag::kLog &&
(!(export_entry->tags & xe::cpu::ExportTag::kHighFrequency) ||
cvars::log_high_frequency_kernel_calls)) {
PrintKernelCall(export_entry, params);
}
KernelTrampoline(FN, std::forward<std::tuple<Ps...>>(params),
std::make_index_sequence<sizeof...(Ps)>());
}
};
export_entry->function_data.trampoline = &X::Trampoline;
return export_entry;
}
} // namespace shim } // namespace shim
using xe::cpu::ExportTag; using xe::cpu::ExportTag;