From efcf61aa9ff638981d9cd173702bebb36f57f49b Mon Sep 17 00:00:00 2001 From: emoose Date: Sun, 5 Jan 2020 19:18:18 +0000 Subject: [PATCH] [CPU] Fix heap corruption by XEXP header patch not resizing headers correctly This should hopefully fix GTA IV's TU (for media ID 6AC07221 at least) --- src/xenia/cpu/xex_module.cc | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/xenia/cpu/xex_module.cc b/src/xenia/cpu/xex_module.cc index bc48c1b0c..617f2f7da 100644 --- a/src/xenia/cpu/xex_module.cc +++ b/src/xenia/cpu/xex_module.cc @@ -248,15 +248,7 @@ int XexModule::ApplyPatch(XexModule* module) { // Patch base XEX header uint32_t original_image_size = module->image_size(); - uint32_t header_target_size = patch_header->delta_headers_target_offset + - patch_header->delta_headers_source_size; - - if (!header_target_size) { - header_target_size = - patch_header->size_of_target_headers; // unsure which is more correct.. - } - - size_t mem_size = module->xex_header_mem_.size(); + uint32_t header_target_size = patch_header->size_of_target_headers; // Increase xex header buffer length if needed if (header_target_size > module->xex_header_mem_.size()) {