From c3415e633281401e03b61407ffa702e731498d5e Mon Sep 17 00:00:00 2001
From: Ben Vanik <ben.vanik@gmail.com>
Date: Wed, 15 Jul 2015 22:20:33 -0700
Subject: [PATCH] Adding TLS abstraction.

---
 src/xenia/base/threading.h             |  8 +++++
 src/xenia/base/threading_win.cc        | 12 +++++++
 src/xenia/kernel/xboxkrnl_threading.cc | 43 ++++----------------------
 3 files changed, 26 insertions(+), 37 deletions(-)

diff --git a/src/xenia/base/threading.h b/src/xenia/base/threading.h
index 70a58699c..351009df5 100644
--- a/src/xenia/base/threading.h
+++ b/src/xenia/base/threading.h
@@ -89,6 +89,14 @@ SleepResult AlertableSleep(std::chrono::duration<Rep, Period> duration) {
       std::chrono::duration_cast<std::chrono::microseconds>(duration));
 }
 
+typedef uint32_t TlsHandle;
+constexpr TlsHandle kInvalidTlsHandle = UINT_MAX;
+
+TlsHandle AllocateTlsHandle();
+bool FreeTlsHandle(TlsHandle handle);
+uintptr_t GetTlsValue(TlsHandle handle);
+bool SetTlsValue(TlsHandle handle, uintptr_t value);
+
 // Results for a WaitHandle operation.
 enum class WaitResult {
   // The state of the specified object is signaled.
diff --git a/src/xenia/base/threading_win.cc b/src/xenia/base/threading_win.cc
index e89dfd35d..fec9c5764 100644
--- a/src/xenia/base/threading_win.cc
+++ b/src/xenia/base/threading_win.cc
@@ -96,6 +96,18 @@ SleepResult AlertableSleep(std::chrono::microseconds duration) {
   return SleepResult::kSuccess;
 }
 
+TlsHandle AllocateTlsHandle() { return TlsAlloc(); }
+
+bool FreeTlsHandle(TlsHandle handle) { return TlsFree(handle) ? true : false; }
+
+uintptr_t GetTlsValue(TlsHandle handle) {
+  return reinterpret_cast<uintptr_t>(TlsGetValue(handle));
+}
+
+bool SetTlsValue(TlsHandle handle, uintptr_t value) {
+  return TlsSetValue(handle, reinterpret_cast<void*>(value)) ? true : false;
+}
+
 template <typename T>
 class Win32Handle : public T {
  public:
diff --git a/src/xenia/kernel/xboxkrnl_threading.cc b/src/xenia/kernel/xboxkrnl_threading.cc
index 26f2b8a81..3176740b2 100644
--- a/src/xenia/kernel/xboxkrnl_threading.cc
+++ b/src/xenia/kernel/xboxkrnl_threading.cc
@@ -11,7 +11,6 @@
 #include "xenia/base/clock.h"
 #include "xenia/base/logging.h"
 #include "xenia/base/mutex.h"
-#include "xenia/base/platform_win.h"
 #include "xenia/cpu/processor.h"
 #include "xenia/kernel/dispatcher.h"
 #include "xenia/kernel/kernel_state.h"
@@ -371,18 +370,10 @@ SHIM_CALL KeQuerySystemTime_shim(PPCContext* ppc_context,
 SHIM_CALL KeTlsAlloc_shim(PPCContext* ppc_context, KernelState* kernel_state) {
   XELOGD("KeTlsAlloc()");
 
-  uint32_t tls_index;
-
-#if XE_PLATFORM_WIN32
-  tls_index = TlsAlloc();
-#else
-  pthread_key_t key;
-  if (pthread_key_create(&key, NULL)) {
+  auto tls_index = xe::threading::AllocateTlsHandle();
+  if (tls_index == xe::threading::kInvalidTlsHandle) {
     tls_index = X_TLS_OUT_OF_INDEXES;
-  } else {
-    tls_index = (uint32_t)key;
   }
-#endif  // WIN32
 
   SHIM_SET_RETURN_32(tls_index);
 }
@@ -398,14 +389,7 @@ SHIM_CALL KeTlsFree_shim(PPCContext* ppc_context, KernelState* kernel_state) {
     return;
   }
 
-  int result = 0;
-
-#if XE_PLATFORM_WIN32
-  result = TlsFree(tls_index);
-#else
-  result = pthread_key_delete(tls_index) == 0;
-#endif  // WIN32
-
+  uint32_t result = xe::threading::FreeTlsHandle(tls_index) ? 1 : 0;
   SHIM_SET_RETURN_32(result);
 }
 
@@ -419,17 +403,10 @@ SHIM_CALL KeTlsGetValue_shim(PPCContext* ppc_context,
   //    "KeTlsGetValue(%.8X)",
   //    tls_index);
 
-  uint64_t value = 0;
-
-#if XE_PLATFORM_WIN32
-  value = (uint64_t)TlsGetValue(tls_index);
-#else
-  value = (uint64_t)pthread_getspecific(tls_index);
-#endif  // WIN32
-
+  uint32_t value = static_cast<uint32_t>(xe::threading::GetTlsValue(tls_index));
   if (!value) {
     // XELOGW("KeTlsGetValue should SetLastError if result is NULL");
-    // TODO(benvanik): SetLastError
+    // TODO(benvanik): SetLastError? Or does user code do this?
   }
 
   SHIM_SET_RETURN_32(value);
@@ -443,15 +420,7 @@ SHIM_CALL KeTlsSetValue_shim(PPCContext* ppc_context,
 
   XELOGD("KeTlsSetValue(%.8X, %.8X)", tls_index, tls_value);
 
-  int result = 0;
-
-#if XE_PLATFORM_WIN32
-  result = TlsSetValue(
-      tls_index, reinterpret_cast<void*>(static_cast<uintptr_t>(tls_value)));
-#else
-  result = pthread_setspecific(tls_index, (void*)tls_value) == 0;
-#endif  // WIN32
-
+  uint32_t result = xe::threading::SetTlsValue(tls_index, tls_value) ? 1 : 0;
   SHIM_SET_RETURN_32(result);
 }